Merge lp://staging/~dave-cheney/juju-core/019-what-happened-to-deploy into lp://staging/~juju/juju-core/trunk

Proposed by Dave Cheney
Status: Work in progress
Proposed branch: lp://staging/~dave-cheney/juju-core/019-what-happened-to-deploy
Merge into: lp://staging/~juju/juju-core/trunk
Diff against target: 363 lines (+52/-12)
12 files modified
environs/cloudinit/cloudinit.go (+3/-0)
environs/cloudinit/cloudinit_test.go (+5/-1)
environs/config.go (+0/-2)
environs/config/config.go (+2/-2)
environs/config/config_test.go (+21/-2)
environs/config_test.go (+10/-2)
environs/ec2/config.go (+1/-1)
environs/ec2/config_test.go (+2/-1)
environs/ec2/local_test.go (+1/-0)
environs/open_test.go (+2/-0)
environs/tools_test.go (+1/-0)
juju/testing/conn.go (+4/-1)
To merge this branch: bzr merge lp://staging/~dave-cheney/juju-core/019-what-happened-to-deploy
Reviewer Review Type Date Requested Status
The Go Language Gophers Pending
Review via email: mp+129334@code.staging.launchpad.net

Description of the change

environs: various: make admin-secret mandatory

admin-secret is now required to compute the initial password.

https://codereview.appspot.com/6659048/

To post a comment you must log in.
664. By Dave Cheney

wip

Unmerged revisions

664. By Dave Cheney

wip

663. By Dave Cheney

wip

662. By Dave Cheney

wip

661. By William Reade

uniter: rework config-changed handling

Specifically, drop the automatic CC on entering ModeAbide; fulfil guarantees
by introducing ModeConfigChanged, invoked in ModeContinue after appropriate
precursor hooks and in ModeAbide when no CC has yet been run by the Uniter.

R=niemeyer
CC=
https://codereview.appspot.com/6632062

660. By Roger Peppe

cmd/jujud: make agents change passwords ASAP

R=niemeyer
CC=
https://codereview.appspot.com/6655044

659. By Roger Peppe

environs: add AgentDir function

This will be used by the machine agent to
store its password in. I realise that the
agent directory structure is expecting an overhaul,
but this should do as a place holder in the
meantime.

We also create the machine agent's directory,
and remove a couple of spurious sudos in passing.

R=niemeyer
CC=
https://codereview.appspot.com/6655043

658. By Roger Peppe

container: start uniter with debug flag set.

R=niemeyer
CC=
https://codereview.appspot.com/6654043

657. By Roger Peppe

various: set passwords in state at bootstrap time.

R=niemeyer
CC=
https://codereview.appspot.com/6632049

656. By Roger Peppe

state: add password test

Add a test to check that appropriate entities
can set the passwords they need to set.
Currently there is no restriction on capabilities,
but this test will be more relevant when we
move to an API-based state.

R=niemeyer
CC=
https://codereview.appspot.com/6636057

655. By William Reade

uniter: HookContext.Config is now consistent

fixes lp:1063619

R=niemeyer
CC=
https://codereview.appspot.com/6642060

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches