Juju Charms Collection
wordpress package

Merge lp://staging/~dave-cheney/charms/precise/wordpress/trunk into lp://staging/charms/wordpress

  1. Precise Pangolin (12.04)
  2. trunk
  3. Merge into trunk
Proposed by Dave Cheney
Status: Merged
Merged at revision: 69
Proposed branch: lp://staging/~dave-cheney/charms/precise/wordpress/trunk
Merge into: lp://staging/charms/wordpress
Diff against target: 34 lines (+11/-7)
1 file modified
hooks/install (+11/-7)
To merge this branch: bzr merge lp://staging/~dave-cheney/charms/precise/wordpress/trunk
Reviewer Review Type Date Requested Status
Marco Ceppi (community) Approve
Review via email: mp+184243@code.staging.launchpad.net

Description of the change

Fixes lp # 1064846

To post a comment you must log in.
Revision history for this message
Marco Ceppi (marcoceppi) wrote :

This looks great, though you've removed the save_pwd bits, which is fine, but the hook needs to cd back to $CHARM_DIR or other hooks will fail when they call hooks/install inline. If you could add the cd back to $CHARM_DIR at the bottom of the hooks/install then I can merge this.

review: Needs Fixing
Revision history for this message
Dave Cheney (dave-cheney) wrote :

Ok, I'll fix that with pushd / popd.

On 06/09/2013, at 21:59, Marco Ceppi <email address hidden> wrote:

> Review: Needs Fixing
>
> This looks great, though you've removed the save_pwd bits, which is fine, but the hook needs to cd back to $CHARM_DIR or other hooks will fail when they call hooks/install inline. If you could add the cd back to $CHARM_DIR at the bottom of the hooks/install then I can merge this.
> --
> https://code.launchpad.net/~dave-cheney/charms/precise/wordpress/trunk/+merge/184243
> You are the owner of lp:~dave-cheney/charms/precise/wordpress/trunk.

lp://staging/~dave-cheney/charms/precise/wordpress/trunk updated
69. By Dave Cheney

responding to review feedback

Revision history for this message
Dave Cheney (dave-cheney) wrote :

ping

Revision history for this message
Dave Cheney (dave-cheney) wrote :

ping

Revision history for this message
Marco Ceppi (marcoceppi) wrote :

LGTM, Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: