Merge lp://staging/~dashua/light-themes/border-less.metacity.and.fixes into lp://staging/~ubuntu-art-pkg/light-themes/trunk

debian/changelog needs combining with what's already there. (move changes to be under the current "UNRELEASED" entry and underneath [James Schriver]. (Also combine Andreas' entries under one name entry).

New bug for tracking the request to re-apply zero-pixels borders (also wants linking in the debian/changelog).

  Bug #740579 ("Wishlist: move to 0px borders now that Unity and Unity-2D/Metacity can cope")

I am not very good at reading metacity's themes. Do you guys have a description or even a screenshot of what it would look like with Metacity (used by Ubuntu Classic without effects and Unity 2D)?

I think I fixed everything :)

Florian: on bug #733431 comment #1 somebody called Florian pasted a screenshot of zero-pixels borders:

  http://launchpadlibrarian.net/66146936/Screenshot.png

Is that what you're after? ;-)

Paul, yes, thanks. I thought we agreed we would _not_ introduce that visual result again.

bug 740576 says "move to 0px borders now that Unity and Unity-2D/Metacity can cope". What does "Unity-2D/Metacity can cope" means?

Hello Florian, I believe (from memory) that the succession of public development conversation has been the following, please correct it if it's wrong:

  (1) bug #733233 - document/implement 0x borders and shadows that were previously only documented/suggested on a private design mailing list
  (2) bug #733431 - document/revert 0px border issues from 'light-themes', reflecting the original concerns expressed on a private mailing list in February that there might be problems (sladen) and subsequently fix Unity-2D to cope (njpatel)
  (3) bug #740576 - document/re-add 0px borders into light-themes - proposal, for discussion, tracking, possible deployment

Specifically on the question of "Unity-2D can cope" this is based on the belief that a fix for (2) to 'unity-2d' may have been committed based. This is based on the status updates made in bug #733431 comment #6.1 and comment 6.2:

  * 2011-03-12: Florian Boucault changed in unity-2d: status: Confirmed → Fix Committed
  * 2011-03-13: Vish on changed in light-themes: status: Fix Committed → Fix Released

Admittedly, the changelogs available for 'unity-2d' in Ubuntu do not record a link to bug #733431 it is not easy to traceback further via the metadata available. In the 'debian/changelog' there is simply a mention of a "New upstream Version release" two days after the above status changes:

  http://changelogs.ubuntu.com/changelogs/pool/main/u/unity-2d/unity-2d_3.6.2-0ubuntu2/changelog

  unity-2d (3.6.2-0ubuntu1) natty; urgency=low
  * New upstream bugfix release
   -- Oliver Grawert <email address hidden> Tue, 15 Mar 2011 17:59:55 +0100

If there is a technical reason why zero-pixel borders will not work on Unity-2D as of 3.6.2-0ubuntu1, it would be most useful to get it documented on bug #740576 as at the moment it would imply that the current title is misleading.

(It's probably worth noting that I, personally, am indifferent and do not have a preference or desire either way. However, I do like discussion, clarity and ability to track the development process with each change *clearly* mapping back to its rationale (the bug report), its implementation (the linked branches) and its deployment (the distro Committed/Released status).

Bug #733431 was marked as Fix Committed in Unity 2D because the bug "Windows lack borders: visually unpleasant and leaves only one option to resize" was fixed. The fix was simply the revert to 1px borders in light-themes.

Making borders 0px again will reopen this very same bug.

To be very clear, no one did any work on the Unity 2D side. Also, it is not specific to Unity 2D, it is a general metacity issue. If there is something to do to support 0px borders without triggering bug #733431, it's there.

I did not know that the task "[...] subsequently fix Unity-2D to cope (njpatel)" was assigned to njpatel nor do I know any plans in that regard.

James: sorry, this is going to be blocked on not having the capability in Metacity. That would need fixing first.

Oh man, should I publish a branch with the other fixes absent the metacity fixes?

James: good thinking, can you resync/merge against lp:light-themes and propose the rest of the changes and then push that (plus the necessary 'debian/changelog' tweaks to reflect the changes).