Ubuntu
grub2 package

Merge lp://staging/~darkmuggle-deactivatedaccount/ubuntu/quantal/grub2/param-recordfail-timeout into lp://staging/ubuntu/quantal/grub2

  1. Quantal (12.10)
  2. param-recordfail-timeout
  3. Merge into quantal
Proposed by Ben Howard
Status: Superseded
Proposed branch: lp://staging/~darkmuggle-deactivatedaccount/ubuntu/quantal/grub2/param-recordfail-timeout
Merge into: lp://staging/ubuntu/quantal/grub2
Diff against target: 73 lines (+53/-0)
3 files modified
debian/changelog (+6/-0)
debian/patches/series (+1/-0)
debian/patches/ubuntu_param_recordfail_timeout.patch (+46/-0)
To merge this branch: bzr merge lp://staging/~darkmuggle-deactivatedaccount/ubuntu/quantal/grub2/param-recordfail-timeout
Reviewer Review Type Date Requested Status
Colin Watson (community) Needs Fixing
Review via email: mp+106720@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2012-05-24.

Commit message

Parameterization of recordfail setting. This allows users to define the
default time out of Grub2 when recordfail has been set. The current
setting causes hangs on appliances and Cloud Images where access to the
console is limited or prohibited. (LP: #669481)

Description of the change

This patch parameterizes the record fail behavior, such that putting "GRUB_RECORDFAIL_TIMEOUT=0" in /etc/default/grub will fix hang problems on appliances and HVM cloud images. (See LP: #462888, #872244, #447725 and #669481 and there are many user reports on Google). The current work-around is to modify /etc/grub.d/00_header directly. However, this work around fails on any Grub2 package update.

This fix simply adds the environment variable "GRUB_RECORDFAIL_TIMEOUT" which can then be defined in /etc/default/grub. When this variable is present, it sets the timeout on "recordfail" to the value, otherwise it sets it the default value of "-1".

This has been tested on both Precise and Quantal builds.

To post a comment you must log in.
lp://staging/~darkmuggle-deactivatedaccount/ubuntu/quantal/grub2/param-recordfail-timeout updated
144. By Ben Howard

Changed the changelong to be more descriptive of the change

Revision history for this message
Colin Watson (cjwatson) wrote :

Please drop the debian/default/grub change. It'll probably cause configuration file prompts for people, and it's unnecessary - most variables are not documented by way of comments in the stock /etc/default/grub file.

Conversely, please add a patch to docs/grub.texi to document this new variable.

review: Needs Fixing
Revision history for this message
Colin Watson (cjwatson) wrote :

Oh, also, a more verbose changelog entry (along the lines of your commit message) wouldn't hurt.

lp://staging/~darkmuggle-deactivatedaccount/ubuntu/quantal/grub2/param-recordfail-timeout updated
145. By Ben Howard

Parameterization of recordfail setting. This allows users to define the
default time out of GRUB when recordfail has been set. The current
setting causes hangs on headless and appliances where access to the
console is limited or prohibited. (LP: #669481)

Unmerged revisions

145. By Ben Howard

Parameterization of recordfail setting. This allows users to define the
default time out of GRUB when recordfail has been set. The current
setting causes hangs on headless and appliances where access to the
console is limited or prohibited. (LP: #669481)

144. By Ben Howard

Changed the changelong to be more descriptive of the change

143. By Ben Howard

Parameterization of recordfail timeout (LP: #669481)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: