neutron

Merge lp://staging/~danwent/neutron/test-show-no-attachment into lp://staging/neutron/essex

test-show-no-attachment
Merge into github

Proposed by dan wendlandt on 2011-09-23

Status:	Merged
Merge reported by:	dan wendlandt
Merged at revision:	not available
Proposed branch:	lp://staging/~danwent/neutron/test-show-no-attachment
Merge into:	lp://staging/neutron/essex
Diff against target:	38 lines (+22/-0) 1 file modified tests/unit/test_api.py (+22/-0)
To merge this branch:	bzr merge lp://staging/~danwent/neutron/test-show-no-attachment
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Salvatore Orlando (community)			Approve on 2011-09-23
Tyler Smith (community)			Approve on 2011-09-23
Brad Hall (community)		2011-09-23	Approve on 2011-09-23
Somik Behera (community)	netstack-core	2011-09-23	Approve on 2011-09-23
Review via email: mp+76801@code.staging.launchpad.net

Description of the change

This does not change functionality.

It adds unit tests to validate how the API performs when fetching a port attachment when no attachment is set.

Revision history for this message

Somik Behera (somikbehera) wrote on 2011-09-23:

Unit test looks good.

review: Approve (netstack-core)

Revision history for this message

Brad Hall (bgh) wrote on 2011-09-23:

Looks good

review: Approve

Revision history for this message

Tyler Smith (tylesmit) wrote on 2011-09-23:

Looks good.

review: Approve

Revision history for this message

dan wendlandt (danwent) wrote on 2011-09-23:

quickest review EVER! thanks :)

On Fri, Sep 23, 2011 at 1:31 PM, Tyler Smith <email address hidden> wrote:

> Review: Approve
>
> Looks good.
> --
>
> https://code.launchpad.net/~danwent/quantum/test-show-no-attachment/+merge/76801
> You are the owner of lp:~danwent/quantum/test-show-no-attachment.
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~

Revision history for this message

James E. Blair (corvus) wrote on 2011-09-23:

dan wendlandt <email address hidden> writes:

> dan wendlandt has proposed merging lp:~danwent/quantum/test-show-no-attachment into lp:quantum.

Hi,

Shouldn't this be in Gerrit?

http://wiki.openstack.org/GerritWorkflow

-Jim

Revision history for this message

dan wendlandt (danwent) wrote on 2011-09-23:

Hi Jim,

This is still for diablo (we delayed our release one day, so it is releasing
today).

dan

On Fri, Sep 23, 2011 at 2:55 PM, James E. Blair <email address hidden> wrote:

> dan wendlandt <email address hidden> writes:
>
> > dan wendlandt has proposed merging
> lp:~danwent/quantum/test-show-no-attachment into lp:quantum.
>
> Hi,
>
> Shouldn't this be in Gerrit?
>
> http://wiki.openstack.org/GerritWorkflow
>
> -Jim
>
> --
>
> https://code.launchpad.net/~danwent/quantum/test-show-no-attachment/+merge/76801
> You are the owner of lp:~danwent/quantum/test-show-no-attachment.
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~

Revision history for this message

Salvatore Orlando (salvatore-orlando) wrote on 2011-09-23:

> dan wendlandt <email address hidden> writes:
>
> > dan wendlandt has proposed merging lp:~danwent/quantum/test-show-no-
> attachment into lp:quantum.
>
> Hi,
>
> Shouldn't this be in Gerrit?
>
> http://wiki.openstack.org/GerritWorkflow
>
> -Jim

Hu Jim,

I think we are still merging into launchpad, as these are 'last-minute' patches into the diablo release, which will come from Launchpad.

Dan, please correct me if I'm wrong.

Revision history for this message

Salvatore Orlando (salvatore-orlando) wrote on 2011-09-23:

Dan, thanks for adding this code.

Just a note: approving this branch implies we accept the current API behavior and hence will keep a malfunctioning Quantum Manager in Nova's diablo release.

Please tell me that I'm wrong.

review: Needs Information

Revision history for this message

dan wendlandt (danwent) wrote on 2011-09-23:

Yes, let's chat about this.

On Fri, Sep 23, 2011 at 3:17 PM, Salvatore Orlando <
<email address hidden>> wrote:

> Review: Needs Information
>
> Dan, thanks for adding this code.
>
> Just a note: approving this branch implies we accept the current API
> behavior and hence will keep a malfunctioning Quantum Manager in Nova's
> diablo release.
>
> Please tell me that I'm wrong.
>
> --
>
> https://code.launchpad.net/~danwent/quantum/test-show-no-attachment/+merge/76801
> You are the owner of lp:~danwent/quantum/test-show-no-attachment.
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~

Revision history for this message

James E. Blair (corvus) wrote on 2011-09-23:

dan wendlandt <email address hidden> writes:

> Hi Jim,
>
> This is still for diablo (we delayed our release one day, so it is releasing
> today).

Oh, in that case maybe this proposal should be targeted to
lp:quantum/diablo instead of lp:quantum? At this point lp:quantum is a
mirror of github.

-Jim

Revision history for this message

Salvatore Orlando (salvatore-orlando) wrote on 2011-09-23:

Agreed to approve after discussion on IRC.

review: Approve

Revision history for this message

dan wendlandt (danwent) wrote on 2011-09-23:

On Fri, Sep 23, 2011 at 3:31 PM, James E. Blair <email address hidden> wrote:

> dan wendlandt <email address hidden> writes:
>
> > Hi Jim,
> >
> > This is still for diablo (we delayed our release one day, so it is
> releasing
> > today).
>
> Oh, in that case maybe this proposal should be targeted to
> lp:quantum/diablo instead of lp:quantum? At this point lp:quantum is a
> mirror of github.
>

Ok, I am actually merging them into lp:quantum/diablo anyway. I will play
with lauchpad to try to make things look sane :)

dan

>
> -Jim
>
> --
>
> https://code.launchpad.net/~danwent/quantum/test-show-no-attachment/+merge/76801
> You are the owner of lp:~danwent/quantum/test-show-no-attachment.
>

--
~~~~~~~~~~~~~~~~~~~~~~~~~~~
Dan Wendlandt
Nicira Networks, Inc.
www.nicira.com | www.openvswitch.org
Sr. Product Manager
cell: 650-906-2650
~~~~~~~~~~~~~~~~~~~~~~~~~~~