Merge ~danilogondolfo/network-manager/+git/ubuntu-1:preinst_script_fix into network-manager:ubuntu/master

Proposed by Danilo Egea Gondolfo
Status: Merged
Approved by: Sebastien Bacher
Approved revision: 8904f74bb6b303aba2186ac5693a39c7ec54825c
Merged at revision: 8904f74bb6b303aba2186ac5693a39c7ec54825c
Proposed branch: ~danilogondolfo/network-manager/+git/ubuntu-1:preinst_script_fix
Merge into: network-manager:ubuntu/master
Diff against target: 55 lines (+19/-3)
3 files modified
debian/changelog (+12/-0)
debian/network-manager.postinst (+4/-1)
debian/network-manager.preinst (+3/-2)
Reviewer Review Type Date Requested Status
Sebastien Bacher Approve
Łukasz Zemczak Approve
Review via email:

Description of the change

Use /var/lib/NetworkManager for backups in the preinst script. As part of the netplan everywhere project we started creating backups of the existing Network Manager configuration before installation on /root but this is causing some problems. See

The side effect of using /var/lib/NetworkManager is that the backups will be removed on apt remove --purge (what is probably what the user wants when they use --purge?)

To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

I think this makes sense. Even if --purge removes it, I think it's fine as it's a conscious decision to purge the package and all of its configuration. I think the NM configuration would be wiped out when --purge is used without the netplan integration anyway, right?

For sure seems a better placement for this than /root.

review: Approve
Revision history for this message
Danilo Egea Gondolfo (danilogondolfo) wrote :

I updated the MR with another fix related to the changes made during the netplan integration. LP: #2022023

Revision history for this message
Sebastien Bacher (seb128) wrote :


review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.


People subscribed via source and target branches