Merge ~danilogondolfo/network-manager/+git/network-manager:new_autopkgtests into ~slyon/network-manager:netplan-integration

Proposed by Danilo Egea Gondolfo
Status: Superseded
Proposed branch: ~danilogondolfo/network-manager/+git/network-manager:new_autopkgtests
Merge into: ~slyon/network-manager:netplan-integration
Diff against target: 106 lines (+63/-4)
1 file modified
debian/tests/nm_netplan.py (+63/-4)
Reviewer Review Type Date Requested Status
Lukas Märdian Approve
Review via email: mp+442688@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2023-05-16.

To post a comment you must log in.
Revision history for this message
Lukas Märdian (slyon) wrote :

Thank you! LGTM. I left one little (non-blocking) inline comment, which you could consider fixing.

This MP depends on some fixes in libnetplan, so we should hold it back until those fixed landed in Mantic. Once that's done (and the new autopkgtests PASS), we should rebase this MP against https://code.launchpad.net/~network-manager/network-manager/+git/ubuntu/+ref/ubuntu/master and get it landed via the offical NetworkManager package.

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches