netplan

Merge ~danilogondolfo/netplan/+git/ubuntu:kinetic_lp1997467_dbus into ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-kinetic

  1. Git
  2. lp:~danilogondolfo/netplan/+git/ubuntu
  3. kinetic_lp1997467_dbus
  4. Merge into ubuntu-kinetic
Proposed by Danilo Egea Gondolfo
Status: Merged
Approved by: Łukasz Zemczak
Approved revision: 2967b8afe84b00e5ec544a0d6ba608f0e1a4d3a6
Merged at revision: 2967b8afe84b00e5ec544a0d6ba608f0e1a4d3a6
Proposed branch: ~danilogondolfo/netplan/+git/ubuntu:kinetic_lp1997467_dbus
Merge into: ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-kinetic
Diff against target: 222 lines (+194/-0)
4 files modified
debian/changelog (+13/-0)
debian/patches/lp1997467/0009-dbus-Build-the-copy-path-correctly.patch (+93/-0)
debian/patches/lp1997467/0010-tests-Add-an-integration-test-for-netplan-dbus.patch (+86/-0)
debian/patches/series (+2/-0)
Reviewer Review Type Date Requested Status
Łukasz Zemczak Approve
Review via email: mp+438307@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Łukasz Zemczak (sil2100) wrote :

Looking good, will merge and release. Discussed with Danilo already that I didn't see the tests/integration/dbus.py test added as part of these changes. Not strictly required, but more testing is never a bad thing, even if it makes the diff bigger.

Anyway, let's proceed!

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches