netplan

Merge ~danilogondolfo/netplan/+git/ubuntu:jammy_lp1997467 into ~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-jammy

Proposed by Danilo Egea Gondolfo on 2023-02-13

Status:

Merged

Merged at revision:

6368d8c533629ec29528927fc392dbaa71e209c8

Proposed branch:

~danilogondolfo/netplan/+git/ubuntu:jammy_lp1997467

Merge into:

~ubuntu-core-dev/netplan/+git/ubuntu:ubuntu-jammy

Diff against target:

1000 lines (+939/-0)

9 files modified

debian/changelog (+10/-0)
debian/libnetplan0.symbols (+1/-0)
debian/patches/lp1997467/0003-generate-util-fix-double-slash-root-filepath.patch (+55/-0)
debian/patches/lp1997467/0004-test-cli-set-add-regression-cases-for-LP-1997467.patch (+65/-0)
debian/patches/lp1997467/0005-parse-Allow-loading-nullable-origin-hint-overrides-n.patch (+261/-0)
debian/patches/lp1997467/0006-cli-set-fix-origin-hint-handling-LP-1997467.patch (+189/-0)
debian/patches/lp1997467/0007-src-parse-netplan-write-global-renderer-depending-on.patch (+318/-0)
debian/patches/lp1997467/0008-src-parse-plug-memory-leaks-in-nullable-handling.patch (+33/-0)
debian/patches/series (+7/-0)

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Lukas Märdian		2023-02-13	Approve on 2023-02-13
Review via email: mp+437205@code.staging.launchpad.net

Revision history for this message

Lukas Märdian (slyon) wrote on 2023-02-13:

Thanks, LGTM, mostly.

Just a few nitpicks which we might want to fix:

d/changelog: Please mention the additional memory leak patch, otherwise the SRU team might complain about unlisted changes. E.g.:
```
  * d/p/lp1997467: set only specific origin-hint if given (LP: #1997467)
    Cherry-picked from upstream: https://github.com/canonical/netplan/pull/299
    - d/libnetplan0.symbols: Add netplan_parser_load_nullable_overrides() API
    - d/p/0008-src-parse-plug-memory-leaks-in-nullable-handling.patch backport
      upstream commit 40c53bb (memory leak fixup of PR#299)
```
=> please squash this change into your "Update changelog" commit

* cleanup the git history a bit:
=> please squash "458290c Adjust the symbol version to this release" into "aff434f d/libnetplan0.symbols: Add netplan_parser_load_nullable_overrides() API"

=> in "47c66f3 Add the last patch related to the bug-fix" please mention where this patch comes from, by using DEP-3 patch headers (https://dep-team.pages.debian.net/deps/dep3/) and potentially also mentioning it in the git commit message (and/or d/changelog).