Ubuntu
command-not-found package

Merge lp://staging/~danilo/ubuntu/raring/command-not-found/python2-package into lp://staging/ubuntu/raring/command-not-found

  1. Raring (13.04)
  2. python2-package
  3. Merge into raring
Proposed by Данило Шеган
Status: Merged
Merge reported by: Barry Warsaw
Merged at revision: not available
Proposed branch: lp://staging/~danilo/ubuntu/raring/command-not-found/python2-package
Merge into: lp://staging/ubuntu/raring/command-not-found
Diff against target: 90 lines (+25/-2)
5 files modified
debian/changelog (+6/-0)
debian/command-not-found.install (+1/-1)
debian/control (+14/-0)
debian/python-commandnotfound.install (+1/-0)
debian/rules (+3/-1)
To merge this branch: bzr merge lp://staging/~danilo/ubuntu/raring/command-not-found/python2-package
Reviewer Review Type Date Requested Status
Barry Warsaw (community) Approve
Ubuntu branches Pending
Review via email: mp+149494@code.staging.launchpad.net

Description of the change

Provide a python-commandnotfound package which installs CommandNotFound into Python2 paths as well.

This is a solution for bug 1123193.

Some improvements already done as per https://code.launchpad.net/~danilo/ubuntu/quantal/command-not-found/python2-package/+merge/147965

To post a comment you must log in.
Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Thanks a lot for your work here!

Only minor issues are remaining:

- lintian emits:

    W: python-commandnotfound: wrong-section-according-to-package-name python-commandnotfound => python
    I: python-commandnotfound: extended-description-is-probably-too-short
    I: command-not-found source: duplicate-short-description command-not-found python-commandnotfound

- Is the build-dependency on python[3]-dev really needed?

Revision history for this message
Данило Шеган (danilo) wrote :

Here're the simple fixes. I'll need to double check the python3?-dev deps since it was originally in.

Revision history for this message
Barry Warsaw (barry) wrote :

Hmm, I wonder if we shouldn't restructure this package in a better, more Debian Python policy compliant way.

Meaning, the following binary packages:

 * python-commandnotfound - Python 2 library
 * python3-commandnotfound - Python 3 library
 * command-not-found-data - unchanged
 * command-not-found - everything else

Obviously command-not-found would Depends on python3-commandnotfound

Revision history for this message
Barry Warsaw (barry) wrote :

How about verifying and updating Standards-Version too?

Revision history for this message
Barry Warsaw (barry) wrote :

Also, is --without=python-support really necessary?

review: Needs Fixing
Revision history for this message
Bryce Harrington (bryce) wrote :

[Setting to WIP to remove this from sponsor queue; please set back to Needs Review once it's ready for review again.]

Revision history for this message
Barry Warsaw (barry) wrote :

I'm going to fix these problems and upload - thanks Danilo!

Revision history for this message
Barry Warsaw (barry) :
review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

Thanks Barry: it'd probably take me days to get all of that fixed considering my packaging experience :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches