Merge lp://staging/~danilo/ubuntu/quantal/command-not-found/python2-package into lp://staging/ubuntu/quantal/command-not-found

Proposed by Данило Шеган
Status: Work in progress
Proposed branch: lp://staging/~danilo/ubuntu/quantal/command-not-found/python2-package
Merge into: lp://staging/ubuntu/quantal/command-not-found
Diff against target: 100 lines (+35/-2)
5 files modified
debian/changelog (+18/-0)
debian/command-not-found.install (+1/-1)
debian/control (+12/-0)
debian/python-command-not-found.install (+1/-0)
debian/rules (+3/-1)
To merge this branch: bzr merge lp://staging/~danilo/ubuntu/quantal/command-not-found/python2-package
Reviewer Review Type Date Requested Status
Данило Шеган (community) Needs Resubmitting
Dmitry Shachnev Needs Fixing
Zygmunt Krynicki (community) Approve
Ubuntu branches Pending
Review via email: mp+147965@code.staging.launchpad.net

Description of the change

Introduce python-command-not-found package with Python2 results: rely on built-in Debian helpers.

I've added build-deps based on what was removed in r90 previously when the package was ported to Python3.

I'm interested in any comments, especially what do I need to do if it's acceptable to get this into a release (eg. if I should make a branch against trunk/raring instead).

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1 looks good for me

review: Approve
95. By Данило Шеган

Add python-distutils-extra to build-deps.

96. By Данило Шеган

Fix the version number.

Revision history for this message
Данило Шеган (danilo) wrote :

Zygmunt, thanks for the review.

I found out that my last minute changes to only reintroduce build-deps removed in r90 have missed on python-distutils-extra which was needed for dh_auto_build.

Re-added that and testing in my PPA.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

Thanks Danilo

Note that I won't be able to approve this as I have no per-package upload rights to c-n-f (I should probably get that somehow so that I can maintain this project).

Revision history for this message
Данило Шеган (danilo) wrote :

Right, understood (I've noticed the "(Community)" tag in the reviewers column above): I still appreciate the review! :)

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

Leaving the fact I don't like the idea apart, there are some issues:

- the package name should be python-commandnotfound according to <http://www.debian.org/doc/packaging-manuals/python-policy/ch-module_packages.html#s-package_names>, also, the section should be "python";
- the binary package is currently empty (for me);
- finally, please merge two changelog entries and target raring.

review: Needs Fixing
Revision history for this message
Данило Шеган (danilo) wrote :

Dimtry, thanks for the review.

As for the idea, I followed Barry's guide to introducing Python 3 support in reverse: http://www.wefearchange.org/2012/01/debian-package-for-python-2-and-3.html

Any better suggestions on how to solve this particular problem?

I'll look into the empty binary package issue.

I'll also fix the changelog entry and propose a merge against trunk.

Revision history for this message
Stéphane Graber (stgraber) wrote :

Marking as work in progress based on above comments, move back to needs review once you're done. Thanks.

Revision history for this message
Dmitry Shachnev (mitya57) wrote :

> Any better suggestions on how to solve this particular problem?

What do you mean? The empty-binary-package issue should be fixed by adding an .install file.

97. By Данило Шеган

Add .install file.

Revision history for this message
Данило Шеган (danilo) wrote :

The particular problem of us needing a Python2 library providing CommandNotFound (since you said you dislike the idea itself). What alternative would you suggest that you feel is better (I am happy to hear it out, since I am far from experienced with packaging)? .install file should be provided, I hope I haven't forgot to bzr add it ;)

Revision history for this message
Данило Шеган (danilo) wrote :

I've created a separate branch off the trunk branch and proposed a merge: https://code.launchpad.net/~danilo/ubuntu/raring/command-not-found/python2-package/+merge/149494

I'll mark this one as obsolete.

Revision history for this message
Данило Шеган (danilo) :
review: Needs Resubmitting
Revision history for this message
Данило Шеган (danilo) wrote :

Can't do it myself.

Unmerged revisions

97. By Данило Шеган

Add .install file.

96. By Данило Шеган

Fix the version number.

95. By Данило Шеган

Add python-distutils-extra to build-deps.

94. By Данило Шеган

Add python-command-not-found package with Python2 details.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches