Merge lp://staging/~danilo/launchpad/subscribers-list-js into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 12945 |
Proposed branch: | lp://staging/~danilo/launchpad/subscribers-list-js |
Merge into: | lp://staging/launchpad |
Prerequisite: | lp://staging/~danilo/launchpad/bug-770241 |
Diff against target: |
535 lines (+324/-100) 4 files modified
lib/lp/bugs/javascript/bugtask_index_portlets.js (+22/-61) lib/lp/bugs/javascript/subscribers_list.js (+38/-3) lib/lp/bugs/javascript/tests/test_subscribers_list.html (+4/-0) lib/lp/bugs/javascript/tests/test_subscribers_list.js (+260/-36) |
To merge this branch: | bzr merge lp://staging/~danilo/launchpad/subscribers-list-js |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
j.c.sackett (community) | Approve | ||
Review via email: mp+59387@code.staging.launchpad.net |
Commit message
[r=jcsackett]
Description of the change
= Bug subscribers list: user link removal =
Move user link removal to the newly started subscribers_list module and add tests for it.
== Proposed fix ==
remove_
- used every time as anim.on('end') handler together with reset()
- simply doing node.remove() which requires no separate method
So, I've joined it all together, added tests and moved it to bugs.subscriber
== Implementation details ==
- bugtask_
- tests are relatively comprehensive, and because of the green_flash animation taking a full second, a bit slow :/
- I am still working on more clean-ups in bugtask_
- Tests have been slightly refactored to share more code for set-up
== Tests ==
lib/lp/
== Demo and Q/A ==
1. Mark https:/
2. "Subscribe someone else" on bug 2 (eg. ubuntu-team)
3. "Subscribe (the same) someone else" on bug 1.
4. Subscribe yourself
4. Reload bug 1 page.
5. Play with unsubscribe icons
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
This looks good to me. Thanks for explaining the undefined default thing to me.