Merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-sections into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Brad Crittenden |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13243 |
Proposed branch: | lp://staging/~danilo/launchpad/bug-772754-other-subscribers-sections |
Merge into: | lp://staging/launchpad |
Prerequisite: | lp://staging/~danilo/launchpad/bug-772754-base |
Diff against target: |
844 lines (+721/-14) 2 files modified
lib/lp/bugs/javascript/subscribers_list.js (+221/-1) lib/lp/bugs/javascript/tests/test_subscribers_list.js (+500/-13) |
To merge this branch: | bzr merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-sections |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Brad Crittenden (community) | approve | Approve | |
Review via email:
|
Description of the change
= Bug 772754: Other subscribers list, part 1 =
This branch is the start of providing list of other subscribers using
the newly proposed layout from bug 772754 (look at Gary's mockup at https:/
This introduces code to manage different subscription level section
nodes in the list.
It is actually made against Gary's lp:~gary/launchpad/bug-772754-2 branch, but I keep it in a pipeline as bug-772754-base for easier manipulation and merging.
== Tests ==
lp/bugs/
== Demo and Q/A ==
N/A
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
Hi Danilo,
I really like your approach to JS development and enjoy learning from your branches.
Things like the CSS_CLASSES dict are a nice touch to encapsulate info in a DRY fashion.
* Y.Node. create( '<div>< /div>') can be written as Y.Node.create('<div />') and many find it more readable. YUI does the right thing, so you can even use it on elements that aren't really allowed to be self-closing.
* Defining 'level' at first use, maybe in getOrCreateSection, would be helpful.
I see you use a lot of bare comparisons against null and undefined whereas others seem to prefer to use the Y.Lang tests. Are they equivalent? Perhaps this is an issue we should decide on and put in our (as yet mythical) JS Guidelines. Your thoughts are appreciated.
Thanks for catching the feature flag that I think should've already been removed.