Merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-lp-names into lp://staging/launchpad

Proposed by Данило Шеган
Status: Merged
Approved by: Данило Шеган
Approved revision: no longer in the source branch.
Merged at revision: 13243
Proposed branch: lp://staging/~danilo/launchpad/bug-772754-other-subscribers-lp-names
Merge into: lp://staging/launchpad
Prerequisite: lp://staging/~danilo/launchpad/bug-772754-other-subscribers-sections
Diff against target: 412 lines (+398/-0)
3 files modified
lib/lp/app/javascript/lp-names.js (+122/-0)
lib/lp/app/javascript/tests/test_lp_names.html (+24/-0)
lib/lp/app/javascript/tests/test_lp_names.js (+252/-0)
To merge this branch: bzr merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-lp-names
Reviewer Review Type Date Requested Status
Benji York (community) code Approve
Review via email: mp+64178@code.staging.launchpad.net

Description of the change

= Bug 772754: Other subscribers list, part 2 =

This branch provides some helper functions that are used in bug 772754
other subscribers implementation, but that are generally useful as well:
functions to convert from Launchpad valid_name to CSS class name and back.

I plan to announce on-list once they land so people can consider using
them in the future instead of always coming up with their own variants
which might be less complete and non-bijective.

== Tests ==

lib/lp/app/javascript/tests/test_lp_names.html

== Demo and Q/A ==

N/A

= Launchpad lint =

Checking for conflicts and issues in changed files.

Linting changed files:
  lib/lp/app/javascript/lp-names.js
  lib/lp/app/javascript/tests/test_lp_names.html
  lib/lp/app/javascript/tests/test_lp_names.js

To post a comment you must log in.
Revision history for this message
Benji York (benji) wrote :

This branch looks good.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.