Merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-loading into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Данило Шеган |
Approved revision: | no longer in the source branch. |
Merged at revision: | 13243 |
Proposed branch: | lp://staging/~danilo/launchpad/bug-772754-other-subscribers-loading |
Merge into: | lp://staging/launchpad |
Prerequisite: | lp://staging/~danilo/launchpad/bug-772754-other-subscribers-activity |
Diff against target: |
933 lines (+781/-2) 11 files modified
lib/lp/bugs/browser/bugsubscription.py (+54/-1) lib/lp/bugs/browser/configure.zcml (+6/-0) lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+147/-0) lib/lp/bugs/configure.zcml (+1/-0) lib/lp/bugs/interfaces/bug.py (+9/-0) lib/lp/bugs/javascript/subscribers_list.js (+162/-0) lib/lp/bugs/javascript/tests/test_subscribers_list.js (+352/-0) lib/lp/bugs/model/bug.py (+11/-0) lib/lp/bugs/model/tests/test_bug.py (+31/-0) lib/lp/bugs/templates/bug-portlet-subscribers.pt (+1/-0) lib/lp/bugs/templates/bugtask-index.pt (+7/-1) |
To merge this branch: | bzr merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-loading |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Graham Binns (community) | code | Approve | |
Review via email: mp+64186@code.staging.launchpad.net |
Description of the change
= Bug 772754: Other subscribers list, part 5 =
Warning: oversized branch. Perhaps should have split it up into server-side and JS branches.
This is part of ongoing work for providing the "other subscribers" list as indicated in mockup https:/
This branch builds on top of the previous branches and provides finally ties in all the SubscribersList JS code with the actual subscribers loading.
To do the loading, method getDirectSubscr
For 'Maybe notified' subscribers, we are using existing APIs (getIndirectSub
Output of these methods is further hooked up into view +bug-portlet-
Note how this doesn't really remove any of the existing subscribers loading, so you end up with two subscribers lists after this.
It is comprehensively tested (I believe). An integration test would be nice, but definitely for a later branch.
Considering the branch is over-sized already, I didn't bother looking into model/bug.py lint issues (except that I made sure I introduced no new ones).
Another thing I am unsure about is if I should move BugSubscribersL
== Tests ==
lp/bugs/
bin/test -cvvt BugPortletSubsc
== Demo and Q/A ==
N/A
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
./lib/lp/
52: 'SQLRaw' imported but unused
52: 'Join' imported but unused
52: 'Exists' imported but unused
171: 'get_bug_
52: 'Count' imported but unused
303: E301 expected 1 blank line, found 0
2607: E225 missing whitespace around operator
make: *** [lint] Error 7