Merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-actions into lp://staging/launchpad
| Status: | Merged |
|---|---|
| Merged at revision: | 13243 |
| Proposed branch: | lp://staging/~danilo/launchpad/bug-772754-other-subscribers-actions |
| Merge into: | lp://staging/launchpad |
| Prerequisite: | lp://staging/~danilo/launchpad/bug-772754-other-subscribers-loading |
| Diff against target: |
912 lines (+680/-17) 7 files modified
lib/lp/bugs/browser/bugsubscription.py (+8/-1) lib/lp/bugs/browser/tests/test_bugsubscription_views.py (+11/-1) lib/lp/bugs/javascript/bugtask_index_portlets.js (+0/-1) lib/lp/bugs/javascript/subscribers_list.js (+172/-9) lib/lp/bugs/javascript/tests/test_subscribers_list.html (+4/-0) lib/lp/bugs/javascript/tests/test_subscribers_list.js (+483/-4) lib/lp/bugs/templates/bugtask-index.pt (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~danilo/launchpad/bug-772754-other-subscribers-actions |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Brad Crittenden (community) | code | Approve | |
|
Review via email:
|
|||
Description of the change
= Bug 772754: Other subscribers list, part 6 =
Warning: slightly over-sized as well, mostly for the long JS tests which emulate lp_client behaviour.
This is part of ongoing work for providing the "other subscribers" list as indicated in mockup https:/
Provides subscribe-
Existing list of subscribers is only removed in the next branch, so with this branch, you have two lists of which only this one will now really work.
== Tests ==
lp/bugs/
bin/test -cvvt BugPortletSubsc
== Demo and Q/A ==
N/A
= Launchpad lint =
Checking for conflicts and issues in changed files.
Linting changed files:
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
lib/lp/
Hi Danilo this branch looks good.