Merge lp://staging/~danilo/launchpad/bug-562450 into lp://staging/launchpad

Proposed by Данило Шеган
Status: Merged
Approved by: Gavin Panella
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp://staging/~danilo/launchpad/bug-562450
Merge into: lp://staging/launchpad
Diff against target: 138 lines (+49/-12)
2 files modified
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+43/-9)
lib/lp/soyuz/model/queue.py (+6/-3)
To merge this branch: bzr merge lp://staging/~danilo/launchpad/bug-562450
Reviewer Review Type Date Requested Status
Gavin Panella (community) Approve
Review via email: mp+23383@code.staging.launchpad.net

Commit message

Do not publish translations for package rebuilds.

Description of the change

= Bug 562450 =

People complain when stuff happens without them being aware of it. One of such things is when translations get imported and attributed to them.

So, we had a rebuild of a package from Intrepid and that ended up causing a translations import. One file had no Last-Translator set, so even translations got assigned to the original packager from few years back. It came as a surprise to the packager.

== Proposed fix ==

From discussion with Julian, we should ignore not just PPAs, but all the packages from archives with purposes not in MAIN_ARCHIVE_PURPOSES. Let's do it.

Lint has a bunch of problems which I am pretty sure have nothing to do with me, and might be related to my system being a bit screwed.

== Tests ==

This would benefit from unit testing which is currently done in a doctest. Ugh. If I didn't have many other important things on my plate, I'd clean it up already. Please don't shoot me.

 bin/test -vvt distroseriesqueue-translations

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/soyuz/doc/distroseriesqueue-translations.txt
  lib/lp/soyuz/model/queue.py

== Pylint notices ==

lib/lp/soyuz/model/queue.py
    23: [F0401] Unable to import 'storm.locals'
    24: [F0401] Unable to import 'storm.store'
    26: [F0401] Unable to import 'zope.component'
    32: [F0401] Unable to import 'lp.archivepublisher.config'
    33: [F0401] Unable to import 'lp.archivepublisher.customupload'
    34: [F0401] Unable to import 'lp.archivepublisher.utils'
    35: [F0401] Unable to import 'lp.archiveuploader.changesfile'
    36: [F0401] Unable to import 'lp.archiveuploader.tagfiles'
    37: [F0401] Unable to import 'lp.archiveuploader.utils'
    38: [F0401] Unable to import 'canonical.cachedproperty'
    39: [F0401] Unable to import 'canonical.config'
    40: [F0401] Unable to import 'canonical.database.constants'
    41: [F0401] Unable to import 'canonical.database.datetimecol'
    42: [F0401] Unable to import 'canonical.database.enumcol'
    44: [F0401] Unable to import 'canonical.encoding'
    45: [F0401] Unable to import 'canonical.launchpad.helpers'
    46: [F0401] Unable to import 'lp.soyuz.interfaces.archive'
    47: [F0401] Unable to import 'lp.soyuz.interfaces.binarypackagerelease'
    49: [F0401] Unable to import 'canonical.launchpad.interfaces.launchpad'
    50: [F0401] Unable to import 'lp.soyuz.interfaces.queue'
    52: [F0401] Unable to import 'lp.registry.interfaces.person'
    53: [F0401] Unable to import 'lp.registry.interfaces.pocket'
    55: [F0401] Unable to import 'lp.soyuz.interfaces.publishing'
    57: [F0401] Unable to import 'lp.soyuz.interfaces.queue'
    63: [F0401] Unable to import 'lp.soyuz.pas'
    64: [F0401] Unable to import 'canonical.launchpad.mail'
    66: [F0401] Unable to import 'lp.soyuz.scripts.processaccepted'
    68: [F0401] Unable to import 'lp.soyuz.scripts.packagecopier'
    69: [F0401] Unable to import 'canonical.librarian.interfaces'
    70: [F0401] Unable to import 'canonical.librarian.utils'
    71: [F0401] Unable to import 'canonical.launchpad.webapp'
    72: [F0401] Unable to import 'canonical.launchpad.webapp.interfaces'
    73: [F0401] Unable to import 'canonical.launchpad.interfaces.lpstorm'
    1678: [F0401, PackageUploadCustom.publish_DEBIAN_INSTALLER] Unable to import 'lp.archivepublisher.debian_installer'
    1687: [F0401, PackageUploadCustom.publish_DIST_UPGRADER] Unable to import 'lp.archivepublisher.dist_upgrader'
    1696: [F0401, PackageUploadCustom.publish_DDTP_TARBALL] Unable to import 'lp.archivepublisher.ddtp_tarball'
    1779: [F0401, PackageUploadSet.findSourceUpload] Unable to import 'lp.registry.model.distroseries'
    1780: [F0401, PackageUploadSet.findSourceUpload] Unable to import 'lp.registry.model.sourcepackagename'
    1781: [F0401, PackageUploadSet.findSourceUpload] Unable to import 'lp.soyuz.model.sourcepackagerelease'

To post a comment you must log in.
Revision history for this message
Gavin Panella (allenap) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.