Merge lp://staging/~danilo/launchpad/bug-562450 into lp://staging/launchpad
Status: | Merged |
---|---|
Approved by: | Gavin Panella |
Approved revision: | no longer in the source branch. |
Merged at revision: | not available |
Proposed branch: | lp://staging/~danilo/launchpad/bug-562450 |
Merge into: | lp://staging/launchpad |
Diff against target: |
138 lines (+49/-12) 2 files modified
lib/lp/soyuz/doc/distroseriesqueue-translations.txt (+43/-9) lib/lp/soyuz/model/queue.py (+6/-3) |
To merge this branch: | bzr merge lp://staging/~danilo/launchpad/bug-562450 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gavin Panella (community) | Approve | ||
Review via email: mp+23383@code.staging.launchpad.net |
Commit message
Do not publish translations for package rebuilds.
Description of the change
= Bug 562450 =
People complain when stuff happens without them being aware of it. One of such things is when translations get imported and attributed to them.
So, we had a rebuild of a package from Intrepid and that ended up causing a translations import. One file had no Last-Translator set, so even translations got assigned to the original packager from few years back. It came as a surprise to the packager.
== Proposed fix ==
From discussion with Julian, we should ignore not just PPAs, but all the packages from archives with purposes not in MAIN_ARCHIVE_
Lint has a bunch of problems which I am pretty sure have nothing to do with me, and might be related to my system being a bit screwed.
== Tests ==
This would benefit from unit testing which is currently done in a doctest. Ugh. If I didn't have many other important things on my plate, I'd clean it up already. Please don't shoot me.
bin/test -vvt distroseriesque
= Launchpad lint =
Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.
Linting changed files:
lib/lp/
lib/lp/
== Pylint notices ==
lib/lp/
23: [F0401] Unable to import 'storm.locals'
24: [F0401] Unable to import 'storm.store'
26: [F0401] Unable to import 'zope.component'
32: [F0401] Unable to import 'lp.archivepubl
33: [F0401] Unable to import 'lp.archivepubl
34: [F0401] Unable to import 'lp.archivepubl
35: [F0401] Unable to import 'lp.archiveuplo
36: [F0401] Unable to import 'lp.archiveuplo
37: [F0401] Unable to import 'lp.archiveuplo
38: [F0401] Unable to import 'canonical.
39: [F0401] Unable to import 'canonical.config'
40: [F0401] Unable to import 'canonical.
41: [F0401] Unable to import 'canonical.
42: [F0401] Unable to import 'canonical.
44: [F0401] Unable to import 'canonical.
45: [F0401] Unable to import 'canonical.
46: [F0401] Unable to import 'lp.soyuz.
47: [F0401] Unable to import 'lp.soyuz.
49: [F0401] Unable to import 'canonical.
50: [F0401] Unable to import 'lp.soyuz.
52: [F0401] Unable to import 'lp.registry.
53: [F0401] Unable to import 'lp.registry.
55: [F0401] Unable to import 'lp.soyuz.
57: [F0401] Unable to import 'lp.soyuz.
63: [F0401] Unable to import 'lp.soyuz.pas'
64: [F0401] Unable to import 'canonical.
66: [F0401] Unable to import 'lp.soyuz.
68: [F0401] Unable to import 'lp.soyuz.
69: [F0401] Unable to import 'canonical.
70: [F0401] Unable to import 'canonical.
71: [F0401] Unable to import 'canonical.
72: [F0401] Unable to import 'canonical.
73: [F0401] Unable to import 'canonical.
1678: [F0401, PackageUploadCu
1687: [F0401, PackageUploadCu
1696: [F0401, PackageUploadCu
1779: [F0401, PackageUploadSe
1780: [F0401, PackageUploadSe
1781: [F0401, PackageUploadSe