Merge lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/normalize-swift-endpoint into lp://staging/~landscape/charms/trusty/glance-simplestreams-sync/landscape

Proposed by Данило Шеган
Status: Rejected
Rejected by: Данило Шеган
Proposed branch: lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/normalize-swift-endpoint
Merge into: lp://staging/~landscape/charms/trusty/glance-simplestreams-sync/landscape
Diff against target: 23 lines (+1/-12)
1 file modified
scripts/glance-simplestreams-sync.py (+1/-12)
To merge this branch: bzr merge lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/normalize-swift-endpoint
Reviewer Review Type Date Requested Status
Данило Шеган (community) Disapprove
Adam Collard (community) Approve
Geoff Teale Pending
Review via email: mp+291612@code.staging.launchpad.net

Description of the change

Swift endpoints being used for uploading images and setting the product streams endpoint are different, thus juju bootstrap cannot find images.

This makes them both use the same URL which has been tested to work.

Testing instructions:

1. Modify OPL to point to cs:~danilo/trusty/glance-simplestreams-sync-11:
   https://pastebin.canonical.com/154011/
2. Enable openstack-image-refresh flag
3. Deploy a cloud
4. Fetch Juju env details and paste them into your ~/.juju/environments.yaml
5. juju bootstrap --debug -e YOUR-OPL-JUJU-ENV

To post a comment you must log in.
64. By Данило Шеган

Clean-up all the useless method calls.

Revision history for this message
Adam Collard (adam-collard) wrote :

Looks good, +1, nice cleanup

review: Approve
Revision history for this message
Данило Шеган (danilo) wrote :

I am throwing this away to replace it with a better fix from

  https://code.launchpad.net/~lathiat/charms/trusty/glance-simplestreams-sync/trunk/+merge/290950

review: Disapprove

Unmerged revisions

64. By Данило Шеган

Clean-up all the useless method calls.

63. By Данило Шеган

Drop AUTH_<tenant-id> bucket from the swift path.

62. By Данило Шеган

Pass ksc in do_sync.

61. By Данило Шеган

Use the AUTH_* path when pushing images to swift store as well.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches