Merge lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/leader-only into lp://staging/~landscape/charms/trusty/glance-simplestreams-sync/landscape
Status: | Rejected |
---|---|
Rejected by: | Данило Шеган |
Proposed branch: | lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/leader-only |
Merge into: | lp://staging/~landscape/charms/trusty/glance-simplestreams-sync/landscape |
Diff against target: | 107 lines (+40/-7) |
To merge this branch: | bzr merge lp://staging/~danilo/charms/trusty/glance-simplestreams-sync/leader-only |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Bogdana Vereha (community) | Approve | ||
Chris Glass (community) | Approve | ||
Review via email: mp+293753@code.staging.launchpad.net |
Description of the change
Make glance-
To avoid changing the structure too much, we do not set-up and destroy cronjobs in leader-change hooks, but instead simply make the cronjob script no-op when not run on the leader unit. Cronjob setup is a bit intricate and involved (there's a per-minute cronjob set initially, along with the cronjob depending on the frequency configured for the service).
Testing instructions:
This charm has been published at cs:~danilo/
See Landscape branch that integrates this charm https:/
Unmerged revisions
- 74. By Данило Шеган
-
Do not drop the glance-
simplestreams- sync per-minute cronjob when not leader inside the script, but manage that from leader-related hooks. - 73. By Данило Шеган
-
Merge landscape charm tip.
- 72. By Данило Шеган
-
Add leader hooks.
- 71. By Данило Шеган
-
Return explicit False (instead of implicit None) in is_leader() on exception.
- 70. By Данило Шеган
-
Strip the returned value from is-leader.
- 69. By Данило Шеган
-
Merge lint fixes from trunk.
- 68. By Данило Шеган
-
Lint fix.
- 67. By Данило Шеган
-
Revert accidental change.
- 66. By Данило Шеган
-
Use a better check for is-leader.
- 65. By Данило Шеган
-
Do not validate full configuration when getting unit_name for juju_run_cmd().
Looks good, one nitpick inline.