Merge lp://staging/~dandrader/unity/phablet_edgeDragInStage into lp://staging/unity/phablet

FAILED: Continuous integration, rev:715
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/1098/
Executed test runs:
    UNSTABLE: http://s-jenkins:8080/job/unity-phablet-qmluitests/1108
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/973
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/973/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/977
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1783

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/1098/rebuild

Noticed a strange issue. Back to "work in progress".

Now it's good.

Wonder if it's worth putting commits 715 and 716 in their own separate merge proposals.

FAILED: Continuous integration, rev:717
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/1105/
Executed test runs:
    FAILURE: http://s-jenkins:8080/job/unity-phablet-qmluitests/1122/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/980
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/980/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/984
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1802

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/1105/rebuild

FAILED: Continuous integration, rev:717
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/1117/
Executed test runs:
    UNSTABLE: http://s-jenkins:8080/job/unity-phablet-qmluitests/1137
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/992
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/992/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/996
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1818

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/1117/rebuild

PASSED: Continuous integration, rev:718
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/1121/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/1141
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/996
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/996/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/1000
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1821

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/1121/rebuild

When tapping or swiping vertically in the reveal area, there's a split-second-long hint when the app comes in. When long-pressing there's some random animation, too.

It also seems that the threshold for completion is too low - if I press and hold near the edge, I can switch the app without really swiping. Maybe the velocity or the distance threshold need to be higher?

> When tapping or swiping vertically in the reveal area, there's a split-second-
> long hint when the app comes in. When long-pressing there's some random
> animation, too.

You mean a split-second shudder before the actual hint animation comes in? That's what I see on the device now. I should have tested on the device before... (doesn't happen on the desktop) :)
Looking into it.

> It also seems that the threshold for completion is too low - if I press and
> hold near the edge, I can switch the app without really swiping.

It's the same with the current implementation: you can switch apps even if your drag is very short.
Same with the panel.

Although I agree it should not be like that, I would rather change that in a separate patch. This one is just about s/DraggingArea/DirectionalDragArea. IMHO I think the user should swipe through at least 40%-50% of the screen width to get it done.

As for the hint animation: I think it would be better to get rid of it altogether. It kinda defeats the purpose of having a directional drag gesture recognition since the user will be disrupted by the hint animation anyway. I have a meeting with John Lea tomorrow about such things.

W dniu 03.06.2013 20:30, Daniel d'Andrada pisze:
>> When tapping or swiping vertically in the reveal area, there's a split-second-
>> > long hint when the app comes in. When long-pressing there's some random
>> > animation, too.
> You mean a split-second shudder before the actual hint animation comes in? That's what I see on the device now. I should have tested on the device before... (doesn't happen on the desktop) :)
> Looking into it.

Yup, that's it.

>> > It also seems that the threshold for completion is too low - if I press and
>> > hold near the edge, I can switch the app without really swiping.
> It's the same with the current implementation: you can switch apps even if your drag is very short.
> Same with the panel.
>
> Although I agree it should not be like that, I would rather change that in a separate patch. This one is just about s/DraggingArea/DirectionalDragArea. IMHO I think the user should swipe through at least 40%-50% of the screen width to get it done.

Works for me.

> As for the hint animation: I think it would be better to get rid of it altogether. It kinda defeats the purpose of having a directional drag gesture recognition since the user will be disrupted by the hint animation anyway. I have a meeting with John Lea tomorrow about such things.

I think it would be OK if the hint was less disruptive, glad you're
talking with John about that.

--
Michał Sawicz <email address hidden>
Canonical Services Ltd.

Fixed.

PASSED: Continuous integration, rev:732
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/1131/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/1154
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/1006
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-armhf-ci/1006/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-raring-i386-ci/1010
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1829

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/1131/rebuild

PASSED: Continuous integration, rev:733
http://jenkins.qa.ubuntu.com/job/unity-phablet-ci/1146/
Executed test runs:
    SUCCESS: http://s-jenkins:8080/job/unity-phablet-qmluitests/1176
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-saucy-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/unity-phablet-saucy-armhf-ci/12/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-saucy-i386-ci/12
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner/1880

Click here to trigger a rebuild:
http://s-jenkins:8080/job/unity-phablet-ci/1146/rebuild