Merge lp://staging/~dan-prince/glance/fix_update_props into lp://staging/~glance-coresec/glance/cactus-trunk
Proposed by
Dan Prince
| Status: | Merged |
|---|---|
| Approved by: | Rick Harris |
| Approved revision: | 106 |
| Merged at revision: | 106 |
| Proposed branch: | lp://staging/~dan-prince/glance/fix_update_props |
| Merge into: | lp://staging/~glance-coresec/glance/cactus-trunk |
| Diff against target: |
71 lines (+32/-0) 3 files modified
bin/glance (+2/-0) glance/registry/db/api.py (+1/-0) tests/functional/test_curl_api.py (+29/-0) |
| To merge this branch: | bzr merge lp://staging/~dan-prince/glance/fix_update_props |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Rick Harris (community) | Approve | ||
| Jay Pipes (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
Updated properties should be marked as deleted=0. This allows previously deleted properties to be reactivated on an update.
Add unit tests to check the above condition.
Also updated the help for bin/glance's 'update' command so that it explicitly states:
Metadata fields that are not specified in the update command will be deleted.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
lgtm. thx Dan.