Merge lp://staging/~daker/webbrowser-app/fix.1248728 into lp://staging/webbrowser-app
Status: | Rejected |
---|---|
Rejected by: | Olivier Tilloy |
Proposed branch: | lp://staging/~daker/webbrowser-app/fix.1248728 |
Merge into: | lp://staging/webbrowser-app |
Diff against target: |
22 lines (+2/-1) 2 files modified
src/Ubuntu/Components/Extras/Browser/ua-overrides.js (+1/-1) src/Ubuntu/Web/ua-overrides-mobile.js (+1/-0) |
To merge this branch: | bzr merge lp://staging/~daker/webbrowser-app/fix.1248728 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Olivier Tilloy | Disapprove | ||
PS Jenkins bot | continuous-integration | Approve | |
Review via email: mp+194555@code.staging.launchpad.net |
Commit message
Use FF OS UA instead of Android
Unmerged revisions
- 406. By Adnane Belmadiaf
-
Merged trunk
Fixed the UA to work with the new override mechanism[ Olivier Tilloy ]
* Use encodeURIComponent() to encode search queries entered in the
address bar. (LP: #1314673)
[ Ubuntu daily release ]
* New rebuild forced
[ Olivier Tilloy ]
* Move version 0.2 of the API to "Ubuntu.Web" namespace, rename
"UbuntuWebView" to "WebView", and document the public API intended
for application developers. The legacy namespace and component name
are kept around for compatibility with existing applications.
Version 0.1 of the API remains untouched (it is deprecated).
Packaging changes: - new qtdeclarative5-ubuntu- web-plugin package
that contains the new namespace and name for the public QML API -
updated runtime dependencies for webbrowser-app, webapp-container
and qtdeclarative5-ubuntu- ui-extras- browser- plugin - updated
descriptions for all packages - added missing multiarch stanza for
webapp-container- autopilot - added missing predepends stanzas for
multiarch packages (LP: #1324180)
[ Michael Sheldon ]
* Filter file uploads based on mime-type information (where available)
[ Alberto Mardegan ]
* Fix the cookies unit tests Make sure that the dbPath always refers
to a file, not a directory. Make sure that even on fast machines (or
machines with a low-accuracy timer) the record timestamps are
unique.
[ Olivier Tilloy ]
* Add a UA override rule for m.youtube.com to allow playing videos.
(LP: #1228415)
* Do not display an empty contextual menu. (LP: #1326752)
[ Alberto Mardegan ]
* Add online account support in the webapp container. A new
"accountProvider" command line parameter has been added to allow one
to specify an account provider for the specific webapp launch. When
used, one can specify a given provider, e.g. "facebook", to pull
existing accounts (if any) from the specified provider from Online
Accounts. When the provider does not have any existing account, an
option to delegate the creation of such an account to OA is
provided. It is also possible to skip the step and go straight to
the target url.
[ Ubuntu daily release ]
* New rebuild forced
[ Olivier Tilloy ]
* Ensure the main page that contains the webviews fills the main view.
(LP: #1321462)
[ Olivier Tilloy ]
* Ensure the current webview is hidden while the activity view is
visible, and work around a bug in oxide that prevented new empty
tabs from rendering.
[ Ubuntu daily release ]
* New rebuild forced
[ Olivier Tilloy ]
* Various optimizations to the activity view. (LP: #1260980)
* Do not override the default height of the TextField that serves as
the address bar. (LP: #1317866)
[ Olivier Tilloy ]
* Fix FTBFS with Qt 5.3. (LP: #1321440)
[ Ubuntu daily release ]
* New rebuild forced
[ Olivier Tilloy ]
* Remove an extraneous whitespace in the default UA on mobile.
[ Michael Sheldon ]
* Add support for downloading images via download manager and content-
hub on non-desktop platforms.
[ Tim Peeters ]
* Push the initial Page on the PageStack.
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Add --local-webapp- manifest webapp container cli option to simplify
the command line in the case of a local manifest.json file
definition. This is to become a bit more important now that the
manifest support thing like ua overrides that would be beneficial to
webapp on touch.
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Add capability for single webapps to have specific UA overrides for
the website that they serve (LP: #1245465)
[ Olivier Tilloy ]
* Enable cross compilation for an ARM target on an X86 host.
* Port autopilot tests to Python 3.
[ Michael Sheldon ]
* Resolve image URLs beginning with a double slash correctly for
context menu items (LP: #1311626)
[ Adnane Belmadiaf ]
* Enabled passwordEchoEnabled (LP: #1314251)
[ Alberto Mardegan ]
* Split UbuntuWebContext into two different components:
UbuntuWebContext, which is a WebContext derivative with the UA
overrides for Ubuntu. UbuntuSharedWebContext, which is a singleton
for UbuntuWebContext .
[ Olivier Tilloy ]
* Build the models in a separate static lib, and link the unit tests
against it. This speeds up build time by avoiding having to
recompile the models’ source for each unit test.
* Handle javascript console messages.
* Escape literal dots in UA override matching regular expressions.
* Enable localStorage by default in the browser. (LP: #1309673)
* Ensure that the URL actually changes so that the address bar is
updated in case the user has entered a new address that redirects to
where she previously was. (LP: #1306615)
* Update bzr ignore rules.
[ Olivier Tilloy ]
* Work around a recent regression by forcing the OSK to show up when
the address bar is being focused. (LP: #1316057)
[ CI bot ]
* Resync trunk
[ Alberto Mardegan ]
* Webapps: let SAML requests through SAML requests are used for
instance by Google Apps for your domain; they are implemented as a
HTTP redirect to a URL containing the query parameter called
"SAMLRequest". Besides letting the request through, we must also add
the SAML domain to the list of the allowed hosts. (LP: #1302780)
[ Ubuntu daily release ]
* New rebuild forced
[ Ubuntu daily release ]
* New rebuild forced
[ Alexandre Abreu ]
* Fix the network dialog reload (LP: #1309138)
* Oxide (and Chromium) does not inform of non user driven navigations
(or more specifically redirects that would be part of an
popup/webview load (after its been granted). Quite a few sites (e.g.
Youtube), create popups when clicking on links (or following a
window.open()) with proper youtube.com address but w/ redirection
params, e.g.:
http://www.youtube. com/redirect? q=http% 3A%2F%2Fgodzill amovie. com%2F&
redir_token=b8WPI1pq9 FHXeHm2bN3KVLAJ Sfp8MTM5NzI2NDg 3NEAxMzk3MTc4ND c0
In this instance the popup & navigation is granted, but then a
redirect happens inside the popup to the real target url (here
http://godzillamovie. com) which is not trapped by a navigation
requested and therefore not filtered. The only way to do it atm is
to listen to url changes in popups & also filter there. (LP:
#1294279)
[ CI bot ]
* Resync trunk
[ Olivier Tilloy ]
* Handle new view requests in the browser. (LP: #1307735)
[ Olivier Tilloy ]
* Force the page title to be reset to an empty string when the
activity view is being hidden. (LP: #1307420)
[ Michael Sheldon ]
* Add support for file upload via content-hub
[ Ugo Riboni ]
* Add support for file upload via content-hub
[ Alexandre Abreu ]
* Make sure that we dont load unecessary libs (oxide or qtwebkit)
correspnding to the webengine that we dont use. (LP: #1306037)
* Add a basic set of integration tests for the webapp container
[ Ubuntu daily release ]
* New rebuild forced
[ Olivier Tilloy ]
* Enable UA overrides for all form factors, each in a separate file.
Add an override for google calendar on desktop. Clean up the
construction of the default UA string for easier reading and
maintenance.
[ Bill Filler ]
* Add support for file upload via content-hub
[ David Barth ]
* To prevent https://bugs.launchpad .net/ubuntu/ +source/ ubuntu- ui-
toolkit/+bug/1305834 caused by a recent UI toolkit change, we are
returning an empty title for now. (LP: #1305834)
[ Alexandre Abreu ]
* Add support for Oxide's onNavigationRequested in the container (LP:
#1302769)
* Webapps: maintain the session cookies for the user session Instruct
Oxide to store/load the session cookies on disk in a per-webapp
directory under XDG_RUNTIME_DIR. The first time in a user session
that the webapp is launched, the session cookies (leftover from
previous sessions) are not loaded, but only stored (this is the
chrome's "persistent" sessionCookieMode). The next times, session
cookies are both loaded and stored (chrome's "restored"
sessionCookieMode).
[ Alberto Mardegan ]
* Webapps: maintain the session cookies for the user session Instruct
Oxide to store/load the session cookies on disk in a per-webapp
directory under XDG_RUNTIME_DIR. The first time in a user session
that the webapp is launched, the session cookies (leftover from
previous sessions) are not loaded, but only stored (this is the
chrome's "persistent" sessionCookieMode). The next times, session
cookies are both loaded and stored (chrome's "restored"
sessionCookieMode).
[ Ubuntu daily release ]
* New rebuild forced
[ Olivier Tilloy ]
* Update to oxide 1.0.
[ Olivier Tilloy ]
* Re-enable javascript dialogs, now that they are available in oxide.
[ CI bot ]
* Resync trunk
[ Alexandre Abreu ]
* Small update to the --webapp flag documentation
[ Olivier Tilloy ]
* Null-check to fix a segmentation fault when --help is passed to the
executable.
[ Olivier Tilloy ]
* Land the master Oxide support branch. See individual revisions for
details. (LP: #1271756)
[ Alexandre Abreu ]
* There are 2 ways for the webapp-container to receive a list of
patterns to filter url browsing in a webapp container: through the
manifest.json file that comes with a given (named) webapp, or
through the command line. At the moment, the 2 mechanisms are
exclusive in the sense that from the webapp-container's perspective
it only considers one or another when filtering navigation (the
webapp manifest one being preferred) but they are NOT semantically
equivalent. The list of url patterns in the manifest.json file is
use as a mean to filter the urls that are being browsed to, but ALSO
in the chromium & FF browsers to know if a webapp is to be
installed/enabled when browsing in a given url. For example, for
Gmail, the hostname mail.google.com is used as a trigger to ask the
user for an installation/enablement of a webapp in the browser. It
is also implicitely used as a filter for browser once in the
container. The issue is that for applications like google services,
the authentication mechanism is common. So when launched in the
container, the user will be redirected to e.g.
https://accounts. google. com or https:/ /accounts. google. ca, etc. So,
the manifest.json cannot be modified to account for those, since we
dont want to install a webapp from those URLs but we need a way to
add extra navigation url patterns to allow google service webapps to
be redirected to e.g. https://accounts. google. * etc. We provide here
2 things: an way for the url patterns passed down from the command
line to be also considered in the navigation filtering,. a way to
simplify url patterns for google apps (LP: #1288982)
[ Olivier Tilloy ]
* Use the renderer only once when rendering a thumbnail. This seems to
fix the crash that was happening at destruction time. (LP: #1294219)
[ Colin Watson ]
* Add multiarch annotations.
[ daker ]
* Fix to open URL that start with / (local files)
[ Leo Arias ]
* Updated the copyright header on all the python files.
[ Adnane Belmadiaf ]
* Fix to open URL that start with / (local files)
[ Olivier Tilloy ]
* Do not register private types in the public plugin. Register them in
the webbrowser application scope instead. I have made sure that
private types that were previously public are currently not being
used by any application in the store, so this refactoring is safe.
* Refactor the test HTTP server to use a random port at startup.
* New rebuild forced
* Reverting as desktop image isn't installable (main/universe
mismatch) and causing all signon-ui tests on Touch failing
*
[ Olivier Tilloy ]
* Do not install the selection event handlers on certain domains known
to interfere with touch events. (LP: #1279903)
[ Ted Gould ]
* Add URL Dispatcher configuration file.
[ Olivier Tilloy ]
* Fix a memory leak when exiting the application.
* Work around bug #1270848 in a different manner to avoid introducing
another regression. (LP: #1270848, #1271436)
[ Ubuntu daily release ]
* Automatic snapshot from revision 444
[ Olivier Tilloy ]
* Work around a bug (regression?) in the UITK by replacing the use of
Page by a simple Item. (LP: #1270848)
[ Ubuntu daily release ]
* Automatic snapshot from revision 439
[ Olivier Tilloy ]
* Bump version to 0.23 in preparation for the next major release.
* Split the app into two executables: webbrowser-app and webapp-
container.
* Cleaner workaround for bug #1248620. Thanks Thomi for the
suggestion!. (LP: #1248620)
* Update the link to the list of overrides for B2G.
* Add ignore rules for generated ninja files.
* Use the local test server everywhere instead of writing temporary
html pages on disk.
* Fix FTBFS with Qt 5.2. (LP: #1258038)
* Ensure the test server is up and responding before starting the
tests, and use standard logging everywhere.
* Re-execute web application in the dedicated container (compatibility
mode for legacy webapps).
[ Omer Akram ]
* move the close button of the running activity to the left.
[ Alexandre Abreu ]
* Further separate the two webbrowser-app & webapp-container projects.
(LP: #1246935)
* Restrict url webapps pattern replacement depending on which part is
being affected. (LP: #1240685)
* Fix back forward hud actions.
[ daker ]
* Fix for uppercase urls. (LP: #1244329)
* Fixed UA string for huffpost.com. (LP: #1223937)
[ Timo Jyrinki ]
* libqt5v8-5-private- dev will be dropped from Qt 5.2. qtdeclarate-
private-dev 5.0.2 now depends on it until then.
[ Adnane Belmadiaf ]
* Change the default homepage to start.ubuntu.com. (LP: #1250995)
* Fixed UA string for huffpost.com. (LP: #1223937)
[ David Barth ]
* Make sure we are redirected to the mobile version automatically, by
presenting a mobile user-agent string on the /whole/ youtube domain
(not just m.youtube.com). The string is also changed to the simpler
ua string used for facebook.com. It gives the same UI, but avoids
being seen as an Apple browser, which itself prevents rtsp/3gp
content to be served to our browser. We (barely) support html5 video
now.
* Re-execute web application in the dedicated container (compatibility
mode for legacy webapps).
[ Ubuntu daily release ]
* Automatic snapshot from revision 435
* Add OA integration. - 405. By Adnane Belmadiaf
-
G+ looks Mobile; to serve the mobile version
- 404. By Adnane Belmadiaf
-
Use FF OS UA instead of Android
I’m hesitant to merge this change without some serious regression testing.
The first step would be to file a bug report to track this specific override, and for each override that we test, document the positive and negative changes that we observe.