Merge lp://staging/~daker/ubuntu-html5-theme/fix.1202349 into lp://staging/ubuntu-html5-theme
Proposed by
Adnane Belmadiaf
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Merged at revision: | 140 | ||||
| Proposed branch: | lp://staging/~daker/ubuntu-html5-theme/fix.1202349 | ||||
| Merge into: | lp://staging/ubuntu-html5-theme | ||||
| Diff against target: |
388 lines (+225/-75) 5 files modified
0.1/ambiance/js/core.js (+1/-1) 0.1/ambiance/js/toolbars.js (+203/-46) examples/html5-theme/apps/rss-reader/app.js (+2/-0) examples/html5-theme/apps/rss-reader/index.html (+2/-1) examples/html5-theme/widgets/Toolbar.html (+17/-27) |
||||
| To merge this branch: | bzr merge lp://staging/~daker/ubuntu-html5-theme/fix.1202349 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Alexandre Abreu | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Add swipe to reveal/hide the toolbar
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
L89: shouldn't refer to global implicit var, should go through the delegate for the touch requests ...
L91: check for null,
L114: the initial state of the toolbar (not visible) should be set,
L146: the semantics is not very clear, ... why on touchleave while it is being said "called when the toolbar is touched" ?
L168: UI reference
L254: nothing returned if id not found?
I am not sure about the approach of forcing the user to go through a toolbar() call just to make a toolbar work properly & as expected instead of relying on the mandatory init() call ...