MAAS

Merge ~d0ugal/maas:node-metadata-lp-1891027 into maas:2.8

  1. Git
  2. lp:~d0ugal/maas
  3. node-metadata-lp-1891027
  4. Merge into 2.8
Proposed by Dougal Matthews
Status: Merged
Approved by: Adam Collard
Approved revision: 9a890ece6ae801505a908a3db9082216c1d59f84
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~d0ugal/maas:node-metadata-lp-1891027
Merge into: maas:2.8
Diff against target: 125 lines (+35/-24)
2 files modified
src/metadataserver/models/scriptset.py (+12/-24)
src/metadataserver/models/tests/test_scriptset.py (+23/-0)
Reviewer Review Type Date Requested Status
MAAS Lander Approve
Adam Collard (community) Approve
Review via email: mp+389147@code.staging.launchpad.net

Commit message

LP: #1891027 Use simpler nodemetadata matching

This simplifies the node metadata matching with a python comparisons and
removes the regular expression and pattern matching
support.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b node-metadata-lp-1891027 lp:~d0ugal/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8128/console
COMMIT: 0affdfe12c4e2ecef7da2f406cd5cdbcfb3306c3

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b node-metadata-lp-1891027 lp:~d0ugal/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8129/console
COMMIT: 1f43eb141426a1bb753bf808150b3e77384df094

review: Needs Fixing
Revision history for this message
Adam Collard (adam-collard) :
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b node-metadata-lp-1891027 lp:~d0ugal/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: b526f406af0ff60aac09cc1e1e736df015b70075

review: Approve
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b node-metadata-lp-1891027 lp:~d0ugal/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8131/console
COMMIT: 9a890ece6ae801505a908a3db9082216c1d59f84

review: Needs Fixing
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b node-metadata-lp-1891027 lp:~d0ugal/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci.internal:8080/job/maas/job/branch-tester/8132/console
COMMIT: 2bfdce77047a4f0c23c9252ca725c9878e432967

review: Needs Fixing
Revision history for this message
Adam Collard (adam-collard) :
review: Approve
Revision history for this message
Adam Collard (adam-collard) wrote :

jenkins: !test

Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b node-metadata-lp-1891027 lp:~d0ugal/maas/+git/maas into -b 2.8 lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 9a890ece6ae801505a908a3db9082216c1d59f84

review: Approve

There was an error fetching revisions from git servers. Please try again in a few minutes. If the problem persists, contact Launchpad support.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches