Merge lp://staging/~d.filoni/telegram-app/fix1642893_1642879 into lp://staging/telegram-app
Proposed by
Devid Antonio Filoni
| Status: | Needs review | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Proposed branch: | lp://staging/~d.filoni/telegram-app/fix1642893_1642879 | ||||||||
| Merge into: | lp://staging/telegram-app | ||||||||
| Diff against target: |
497 lines (+205/-235) 2 files modified
telegram/app/qml/AccountDialogPage.qml (+17/-79) telegram/app/qml/components/TelegramHeader.qml (+188/-156) |
||||||||
| To merge this branch: | bzr merge lp://staging/~d.filoni/telegram-app/fix1642893_1642879 | ||||||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Devid Antonio Filoni (community) | Approve | ||
| Roberto Mier Escandon (community) | Needs Fixing | ||
|
Review via email:
|
|||
Description of the change
This MR fixes bug #1642893 and it should fix bug #1642879. TelegramHeader was not used so I updated and used it to replace PageHeader in AccountDialogPa
I was able to reproduce bug #1642879 during my code changes, I think the reporter is talking about landscape mode.
Tested on desktop (xenial amd64) and mobile (mako).
To post a comment you must log in.
Revision history for this message
| Devid Antonio Filoni (d.filoni) wrote | # |
Revision history for this message
| Devid Antonio Filoni (d.filoni) wrote | # |
review:
Needs Resubmitting
Unmerged revisions
- 252. By Devid Antonio Filoni
-
Apply code changes suggested by rmescandon
- 251. By Devid Antonio Filoni
-
Fix TelegramHeader titles position on landscape mode too.
- 250. By Devid Antonio Filoni
-
Fix TelegramHeader and use it as AccountDialogPage header, fixes bug #1642893 and bug #1642879
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Works as expected. Left a pair of comments below