Merge lp://staging/~d.filoni/telegram-app/audio_receiving_and_sending into lp://staging/telegram-app
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp://staging/~d.filoni/telegram-app/audio_receiving_and_sending | ||||
Merge into: | lp://staging/telegram-app | ||||
Diff against target: |
881 lines (+606/-17) 10 files modified
telegram/app/apparmor-telegram.json (+1/-0) telegram/app/asemantools/asemanaudiorecorder.cpp (+13/-0) telegram/app/asemantools/asemanaudiorecorder.h (+13/-0) telegram/app/qml/AccountSendMessage.qml (+275/-16) telegram/app/qml/MediaPlayerItem.qml (+4/-0) telegram/app/qml/components/AudioRecordingBar.qml (+155/-0) telegram/app/qml/components/TransparentButton.qml (+106/-0) telegram/app/telegram.cpp (+34/-0) telegram/app/telegram.h (+3/-1) telegram/app/telegram.qrc (+2/-0) |
||||
To merge this branch: | bzr merge lp://staging/~d.filoni/telegram-app/audio_receiving_and_sending | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
libqtelegram team | Pending | ||
Review via email: mp+309643@code.staging.launchpad.net |
Description of the change
Hi,
this branch is a port of messing-app voice messages recording&sending feature, it uses internal QML components (AsemanAudioRecord, MediaPlayerItem...) to record and play voice files. It also contains components/
Recorded files are stored in /home/phablet/
The branch is ready so I'm requesting a merge but it should be merged only after bug #1630399 gets fixed: if requested opusenc gstreamer plugin is missing the error will be handled (no crashes) but you won't be able to record anything.
Tested on mako.
Devid
Unmerged revisions
- 243. By Devid Antonio Filoni
-
Trivial code cleanup after merge
- 242. By Devid Antonio Filoni
-
Merge master
- 241. By Devid Antonio Filoni
-
Merge master (rev 253) and resolve conflict in app/qml/
AccountSendMess age.qml - 240. By Devid Antonio Filoni
-
Merge master (rev 252)
- 239. By Devid Antonio Filoni
-
Fix typo in comments
- 238. By Devid Antonio Filoni
-
Do not remove temporary audio files directory if an unsent recorded file exists
- 237. By Devid Antonio Filoni
-
Complete voice sending support (LP: #1375179)
- 236. By Devid Antonio Filoni
-
Merge lp:telegram-app
- 235. By Devid Antonio Filoni
- 234. By Devid Antonio Filoni
-
Add voice messages recording support, requires opus support in QtMultimedia
Commit 238 fixes a bug I introduced in commit 237: the recorded audio files temporary directory was removed also if the user was recording or playing a new file, which is wrong.