Merge lp://staging/~d.filoni/indicator-datetime/lp1364647 into lp://staging/indicator-datetime
Status: | Needs review |
---|---|
Proposed branch: | lp://staging/~d.filoni/indicator-datetime/lp1364647 |
Merge into: | lp://staging/indicator-datetime |
Diff against target: |
478 lines (+380/-2) 5 files modified
CMakeLists.txt (+2/-1) INSTALL (+1/-0) debian/control (+1/-0) include/notifications/sound.h (+1/-0) src/sound.cpp (+375/-1) |
To merge this branch: | bzr merge lp://staging/~d.filoni/indicator-datetime/lp1364647 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Charles Kerr | Pending | ||
Tiago Salem Herrmann | Pending | ||
Indicator Applet Developers | Pending | ||
Review via email: mp+303494@code.staging.launchpad.net |
Description of the change
Hi,
commit 460 MR introduces a libpulse implementation in order to set output port to both spearkers and headphones when playing an alarm as suggested by Pat in comment #17 (bug #1364647) and as already done in telepathy-ofono ( [1] )
commit 461 introduces a g_timeout_
This was tested on Nexus 4 (there is a build in my mako PPA of the same patch).
[1] http://
Unmerged revisions
- 464. By Devid Antonio Filoni
-
Apply code changes suggested by charlesk
- 463. By Devid Antonio Filoni
-
Remove useless g_critical call set during sink port change debug
- 462. By Devid Antonio Filoni
-
Do not restore original sink port on alarm end if port is not available anymore or already active.
- 461. By Devid Antonio Filoni
-
Play alarms through speakers after 5 seconds when speakers are not active (LP: #1364647)
- 460. By Devid Antonio Filoni
-
Prefer speakers over headphones when playing alarm (LP: #1364647)
I found an issue testing commit 461 and fixed it in commit 462: I unplugged headphones after 5 seconds from alarm start (so when port switched to speakers) and closing the notification port was reset to headphones, so audio was not working. With commit 462 headphones port is not restored if it's not available anymore.