Merge lp://staging/~d.filoni/account-polld/lp1481202 into lp://staging/~ubuntu-push-hackers/account-polld/trunk
Proposed by
Devid Antonio Filoni
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Alberto Mardegan | ||||
Proposed branch: | lp://staging/~d.filoni/account-polld/lp1481202 | ||||
Merge into: | lp://staging/~ubuntu-push-hackers/account-polld/trunk | ||||
Diff against target: |
47 lines (+4/-11) 2 files modified
cmd/account-polld/main.go (+1/-1) plugins/plugins.go (+3/-10) |
||||
To merge this branch: | bzr merge lp://staging/~d.filoni/account-polld/lp1481202 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alberto Mardegan (community) | Needs Resubmitting | ||
Jonas G. Drange (community) | Approve | ||
Review via email: mp+304710@code.staging.launchpad.net |
Commit message
Use bool sound value to patch and fix bug #1481202 properly
Description of the change
Hi,
this branch introduces a dbus connection in order to retrieve IncomingMessage
This was tested on mako (rc channel)
Please review this code carefully, I'm not a golang dev
To post a comment you must log in.
Unmerged revisions
- 181. By Devid Antonio Filoni
-
Fix comment again...
- 180. By Devid Antonio Filoni
-
Fix comment
- 179. By Devid Antonio Filoni
-
Revert default notification sound patch and fix bug #1481202 properly
- 178. By Devid Antonio Filoni
-
Properly check if notification sound is in xdg data dirs
- 177. By Devid Antonio Filoni
-
Connect to dbus to get notification sound (LP: #1481202)
Hi,
is there any news about this MR? I don't know who to ping ;)
Thank you!
Devid