Merge lp://staging/~cyruslien/ubiquity/fix-1716369 into lp://staging/ubiquity
Proposed by
Cyrus Lien
Status: | Rejected |
---|---|
Rejected by: | Mathieu Trudel-Lapierre |
Proposed branch: | lp://staging/~cyruslien/ubiquity/fix-1716369 |
Merge into: | lp://staging/ubiquity |
Diff against target: |
19 lines (+5/-2) 1 file modified
ubiquity/nm.py (+5/-2) |
To merge this branch: | bzr merge lp://staging/~cyruslien/ubiquity/fix-1716369 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mathieu Trudel-Lapierre | Disapprove | ||
Review via email: mp+330559@code.staging.launchpad.net |
Description of the change
Add dbus exception handling for:
dbus.exceptions
The error was generated when trying to connect a wpa enterprise ap. (lp:1716369)
To post a comment you must log in.
Unmerged revisions
- 6564. By Cyrus Lien
-
Handle dbus exception when connecting to wpa enterprise ap. (LP: #1716369)
I have nothing against guarding this piece of code against failure, but are you sure this is the correct branch to fix the bug you were seeing?
As far as I can tell, the bug open about this is for WPA Enterprise support, and recent rework of ubiquity for WPA should have properly added support for WPA enterprise. Can you please test the behavior without this patch on artful so we know if we should backport things to xenial?