Merge lp://staging/~cyphermox/ubuntu/maverick/acct/lp682211 into lp://staging/ubuntu/maverick/acct

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merge reported by: Mathieu Trudel-Lapierre
Merged at revision: not available
Proposed branch: lp://staging/~cyphermox/ubuntu/maverick/acct/lp682211
Merge into: lp://staging/ubuntu/maverick/acct
Diff against target: 40 lines (+10/-1)
3 files modified
debian/changelog (+8/-0)
debian/control (+1/-1)
debian/rules (+1/-0)
To merge this branch: bzr merge lp://staging/~cyphermox/ubuntu/maverick/acct/lp682211
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Artur Rona (community) Approve
Review via email: mp+52073@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Artur Rona (ari-tczew) wrote :

Thank you for your time and efforts making Ubuntu better! However, there is an issue:

It looks like cherry-pick from 6.5.4-2.1. However, there are not added Build-Depends on autoconf and automake. Are you sure is it correct?

review: Needs Information
17. By Mathieu Trudel-Lapierre

debian/control: add Build-Depends on autoconf and automake for autoreconf.

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

You're absolutely right, the build-deps on autoconf and automake were missing, I just added them.

Revision history for this message
Artur Rona (ari-tczew) wrote :

ACK. Please any core-dev for upload it.

review: Approve
Revision history for this message
Bryce Harrington (bryce) wrote :

Looks good, uploading

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches