ubuntu-system-settings

Merge lp://staging/~cyphermox/ubuntu-system-settings/lp1346483 into lp://staging/ubuntu-system-settings

  1. lp1346483
  2. Merge into trunk
Proposed by Mathieu Trudel-Lapierre
Status: Merged
Approved by: Iain Lane
Approved revision: 1146
Merged at revision: 1184
Proposed branch: lp://staging/~cyphermox/ubuntu-system-settings/lp1346483
Merge into: lp://staging/ubuntu-system-settings
Diff against target: 13 lines (+2/-1)
1 file modified
plugins/bluetooth/bluetooth.h (+2/-1)
To merge this branch: bzr merge lp://staging/~cyphermox/ubuntu-system-settings/lp1346483
Reviewer Review Type Date Requested Status
Iain Lane (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+239230@code.staging.launchpad.net

Commit message

[bluetooth] make the bluetooth agent a notifyable property.

Description of the change

[bluetooth] make the bluetooth agent a notifyable property.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:1145
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1673/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6138
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4173
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/865
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5766
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7390
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7390/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/14968
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3534
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4523
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4523/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1673/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

Looks like this is only emitted once per instance. Shouldn't this be CONSTANT instead of notifyable?

review: Needs Information
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

There could be reasons in the future to restart the agent, or change it. I think it still makes sense for it to be notifyable.

lp://staging/~cyphermox/ubuntu-system-settings/lp1346483 updated
1146. By Mathieu Trudel-Lapierre

Make the bluetooth agent a constant.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:1146
http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-ci/1706/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/6273
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-utopic/4219
    SUCCESS: http://jenkins.qa.ubuntu.com/job/ubuntu-system-settings-utopic-i386-ci/898
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/5884
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7525
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/7525/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/15156
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-utopic/3576
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4599
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-amd64/4599/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/ubuntu-system-settings-ci/1706/rebuild

review: Approve (continuous-integration)
Revision history for this message
Iain Lane (laney) wrote :

Thanks Mathieu!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches