Merge lp://staging/~cyphermox/ubiquity/oem-config into lp://staging/ubiquity

Proposed by Mathieu Trudel-Lapierre
Status: Merged
Approved by: Mathieu Trudel-Lapierre
Approved revision: 6285
Merged at revision: 6284
Proposed branch: lp://staging/~cyphermox/ubiquity/oem-config
Merge into: lp://staging/ubiquity
Diff against target: 95 lines (+32/-6)
6 files modified
bin/oem-config-firstboot (+2/-0)
bin/oem-config-prepare (+1/-1)
debian/changelog (+20/-0)
debian/oem-config.install (+1/-0)
debian/oem-config.oem-config.service (+1/-5)
debian/oem-config.target (+7/-0)
To merge this branch: bzr merge lp://staging/~cyphermox/ubiquity/oem-config
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Approve
Dimitri John Ledkov (community) Approve
Review via email: mp+255103@code.staging.launchpad.net

Description of the change

oem-config work to better handle systemd -- introducing a new oem-config.target rather than using a flag to control the starting of oem-config.

This also fixes issues with the oem user not always being removed successfully (because it turned out that oem-config would start as well as parts of the graphical.target, so oem could have some processes running)

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) :
review: Approve
6285. By Mathieu Trudel-Lapierre

Remove sleep+kill, it's unnecessary if the graphical target never gets to start (ie. doesn't try to start display-manager)

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

Approving the extra commit, which is a change we discussed on #ubuntu-installer.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: