Pasaffe

Merge lp://staging/~cyphermox/pasaffe/password-length into lp://staging/~mdeslaur/pasaffe/trunk

  1. password-length
  2. Merge into trunk
Proposed by Mathieu Trudel-Lapierre
Status: Merged
Merged at revision: 283
Proposed branch: lp://staging/~cyphermox/pasaffe/password-length
Merge into: lp://staging/~mdeslaur/pasaffe/trunk
Diff against target: 131 lines (+58/-4)
4 files modified
data/apps.pasaffe.gschema.xml (+5/-0)
data/ui/PreferencesPasaffeDialog.ui (+46/-2)
pasaffe/EditDetailsDialog.py (+5/-2)
pasaffe/PreferencesPasaffeDialog.py (+2/-0)
To merge this branch: bzr merge lp://staging/~cyphermox/pasaffe/password-length
Reviewer Review Type Date Requested Status
Marc Deslauriers Approve
Review via email: mp+114322@code.staging.launchpad.net

Description of the change

I'd really personally much rather not reduce password complexity on my systems. I've been using 20 characters now for a little while, grew accustomed to it, and given that the passwords generated by apg are pronounceable, only sometimes include special characters, I'd rather them be longer.

In all; I think the option should be given to users anyway, so this branch adds the necessary UI control and pieces of code to support changing the value.

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

The generated password used to be variable, between 8 and 12 characters. This changes the maximum, but leaves the minimum in place.

Since we're now exposing it in the GUI, perhaps we should make it a fixed number instead of having a variable length?

Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

On Wed, Jul 11, 2012 at 7:46 AM, Marc Deslauriers
<email address hidden> wrote:
> The generated password used to be variable, between 8 and 12 characters. This changes the maximum, but leaves the minimum in place.
>
> Since we're now exposing it in the GUI, perhaps we should make it a fixed number instead of having a variable length?

Ah, that explains the weird shorter passwords I'd see ;)

Yes, I think we should. I think people are free to remove a few
characters from a generated password if they're size-limited by
whatever password policy websites or services enforce.

Mathieu Trudel-Lapierre <email address hidden>
Freenode: cyphermox, Jabber: <email address hidden>
4096R/EE018C93 1967 8F7D 03A1 8F38 732E FF82 C126 33E1 EE01 8C93

Revision history for this message
Marc Deslauriers (mdeslaur) wrote :

Thanks for the patch, ACK!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches