Merge lp://staging/~csurbhi/ubuntu/maverick/mountall/mountall.fix-460246 into lp://staging/ubuntu/maverick/mountall

Proposed by Surbhi Palande
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp://staging/~csurbhi/ubuntu/maverick/mountall/mountall.fix-460246
Merge into: lp://staging/ubuntu/maverick/mountall
Diff against target: 51 lines (+20/-11)
2 files modified
debian/changelog (+7/-0)
src/mountall.c (+13/-11)
To merge this branch: bzr merge lp://staging/~csurbhi/ubuntu/maverick/mountall/mountall.fix-460246
Reviewer Review Type Date Requested Status
Martin Pitt Disapprove
Artur Rona (community) Needs Fixing
Review via email: mp+32785@code.staging.launchpad.net

Description of the change

btrfsck does not accept any switches like -A/-f/-y/-C<fd> as of now. So till these switches are implemented in btrfsck avoid invoking "fsck -t btrfs" with them.

Please do consider merging this for maverick.

To post a comment you must log in.
Revision history for this message
Artur Rona (ari-tczew) wrote :

Surbhi thanks for the patch. Could you update patch for latest package 2.19?

review: Needs Fixing
Revision history for this message
Martin Pitt (pitti) wrote :

The changes still apply cleanly, and natty's btrfsck still doesn't take any switches, so this still applies.

review: Approve
Revision history for this message
Martin Pitt (pitti) wrote :

On second sight, I think we should rather fix btrfsck itself to ignore arguments for now, as proposed in the Debian bug report.

review: Disapprove

Unmerged revisions

335. By Surbhi Palande

btrfsck does not accept any switch as of now. So avoid using any switches
like -a/-C<fd>/-f to btrfsck till these are implemented. (LP: #460246)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches