Merge lp://staging/~cruzjbishop/loggerhead/fix-392668 into lp://staging/loggerhead
Proposed by
Cruz Bishop
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | j.c.sackett | ||||
| Approved revision: | 479 | ||||
| Merged at revision: | 476 | ||||
| Proposed branch: | lp://staging/~cruzjbishop/loggerhead/fix-392668 | ||||
| Merge into: | lp://staging/loggerhead | ||||
| Diff against target: |
56 lines (+19/-1) 3 files modified
loggerhead/__init__.py (+10/-0) loggerhead/templatefunctions.py (+4/-0) loggerhead/templates/macros.pt (+5/-1) |
||||
| To merge this branch: | bzr merge lp://staging/~cruzjbishop/loggerhead/fix-392668 | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| j.c.sackett (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Adds revision number to footer release info, if available.
Description of the change
Fixes bug #392668, displaying the current Loggerhead revision number as well as the release
If the loggerhead instance is not in a branch (not pulled from launchpad, but copied from the folder without the .bzr folders), it only displays the version
To post a comment you must log in.
Revision history for this message
| Cruz Bishop (cruzjbishop) wrote | # |
Revision history for this message
| Cruz Bishop (cruzjbishop) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
This looks pretty good, but I think I would rather have the revision not be shown if it's unknown. You could just set __revision__ == None and then put a tal condition around the display.
My reasoning being that if there isn't a branch, it's probably being deployed via package of some sort, and "Revision Unknown" isn't really useful information in that instance (or any instance in which it's unknown, really).