Merge lp://staging/~cristiklein/ubuntu/saucy/vm-builder/lp468809 into lp://staging/ubuntu/saucy/vm-builder

Proposed by Cristian Klein
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp://staging/~cristiklein/ubuntu/saucy/vm-builder/lp468809
Merge into: lp://staging/ubuntu/saucy/vm-builder
Diff against target: 57 lines (+21/-0)
3 files modified
VMBuilder/plugins/ubuntu/dapper.py (+8/-0)
VMBuilder/plugins/ubuntu/distro.py (+7/-0)
debian/changelog (+6/-0)
To merge this branch: bzr merge lp://staging/~cristiklein/ubuntu/saucy/vm-builder/lp468809
Reviewer Review Type Date Requested Status
Serge Hallyn Disapprove
Ubuntu branches Pending
Review via email: mp+172993@code.staging.launchpad.net

Description of the change

A popular request is to allow ubuntu-vm-builder to add packages from a 3rd-party repository (not a PPA). For example, one might want to install Cassandra in an Ubuntu Saucy VM. Previously, this was only possible using the "--firstboot" option and a carefully-written script.

This branch enables support for adding 3rd party repositories from a file. More precisely, it adds the "--addsourcefile" option which tells ubuntu-vm-builder to copy a certain file to the VM's /etc/apt/sources.list.d/ folder.

For example, assuming one already has Cassandra's repository on the current system, a Cassandra-ready VM can be created as follows:

  sudo ./ubuntu-vm-builder kvm saucy --addsourcefile /etc/apt/sources.list.d/cassandra.list --addpkg cassandra

To post a comment you must log in.
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

Maybe this should go into lp:vmbuilder upstream project?
Requesting review from Serge Hallyn.

Revision history for this message
Serge Hallyn (serge-hallyn) wrote :

Thanks - the patch looks good, but yes please submit this as a patch against lp:vmbuilder. The package branches get automatically created from that.

Marking Disapprove for saucy/vmbuilder, but I Approve the same patch for lp:vmbuilder.

review: Disapprove
Revision history for this message
Martin Pitt (pitti) wrote :

Closing MP, see above comments. I can't push that delta to lp:vmbuilder myself, as I'm not in the owning team.

Unmerged revisions

57. By Cristian Klein

Added option to include additional files in /etc/apt/sources.list.d/. (LP: #468809)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches