Code review comment for lp://staging/~credativ/ocb-server/7.0-lp1166886

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Thanks a lot for this, but I think Olivier raises very valid points here. Anyway, ocb is not meant for feature extensions on such a scale, so I disapprove (for this proposal against this branch).
The read_group trickery Olivier mentions worked very well for me when I needed it.

But I would love to see you following along the lines he proposes in 2., this is a very useful improvement in my opinion!

review: Disapprove

« Back to merge proposal