Merge lp://staging/~cr3/checkbox/optical_write_test into lp://staging/checkbox

Proposed by Marc Tardif
Status: Rejected
Rejected by: Marc Tardif
Proposed branch: lp://staging/~cr3/checkbox/optical_write_test
Merge into: lp://staging/checkbox
Diff against target: 20 lines (+2/-1)
1 file modified
scripts/optical_write_test (+2/-1)
To merge this branch: bzr merge lp://staging/~cr3/checkbox/optical_write_test
Reviewer Review Type Date Requested Status
Marc Tardif (community) Disapprove
Sylvain Pineau (community) Needs Information
Review via email: mp+125885@code.staging.launchpad.net

Description of the change

This doesn't deserve a changelog entry because it is only to fix this merge request that should not have been merged:

  https://code.launchpad.net/~sylvain-pineau/checkbox/bug1052803/+merge/125796

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

If the script is intended to be only use with checkbox, I would say ok, but what if a tester decides to copy it to his/her $HOME ? And just optical_writer, not ansi_parser.

review: Needs Information
Revision history for this message
Marc Tardif (cr3) wrote :

Can't find the button in Launchpad to supersede this branch by:

https://code.launchpad.net/~sylvain-pineau/checkbox/bug1052803/+merge/125952

So, setting this branch as disapprove instead. Ugh...

review: Disapprove

Unmerged revisions

1699. By Marc Tardif

Fixed hard coded path to /usr/share/checkbox/scripts.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches