Merge lp://staging/~cr3/checkbox/838123 into lp://staging/checkbox
Proposed by
Marc Tardif
| Status: | Merged |
|---|---|
| Merged at revision: | 1034 |
| Proposed branch: | lp://staging/~cr3/checkbox/838123 |
| Merge into: | lp://staging/checkbox |
| Diff against target: |
841 lines (+619/-34) 10 files modified
checkbox/report.py (+39/-12) checkbox/tests/report.py (+1/-1) data/whitelists/default.whitelist (+1/-0) debian/changelog (+1/-0) debian/control (+1/-1) jobs/info.txt.in (+9/-0) plugins/launchpad_prompt.py (+2/-2) plugins/launchpad_report.py (+25/-18) plugins/report_prompt.py (+7/-0) report/hardware-1_0.rng (+533/-0) |
| To merge this branch: | bzr merge lp://staging/~cr3/checkbox/838123 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Daniel Manrique (community) | Approve | ||
| Marc Tardif (community) | Needs Resubmitting | ||
|
Review via email:
|
|||
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The bug report has no steps to reproduce so I was unable to check what happens with a borked xml submission file. It looks fine to me, there are no errors in the logs from a normal run.
There's one thing I observed, though: when I try to open the report it looks ugly :( this is because in checkbox.xsl the CHECKBOX_SHARE variable is not substituted and there's stuff like:
href="%
if I replace %(CHECKBOX_SHARE)s with the actual path where the files reside, all works well.
This is worth fixing, because there are usually compliments about how nice the report looks, and if this slips by, we won't get those anymore :)