checkbox-core

Merge lp://staging/~cr3/checkbox-core/shadowd into lp://staging/checkbox-core

  1. shadowd
  2. Merge into trunk
Proposed by Marc Tardif
Status: Merged
Merged at revision: 18
Proposed branch: lp://staging/~cr3/checkbox-core/shadowd
Merge into: lp://staging/checkbox-core
Diff against target: 1021 lines (+513/-132)
14 files modified
bin/checkbox-shadowd (+30/-0)
checkbox/daemon/client.py (+8/-2)
checkbox/daemon/operation.py (+2/-2)
checkbox/daemon/server.py (+10/-7)
checkbox/daemon/subsystem.py (+4/-0)
checkbox/journal/event.py (+81/-25)
checkbox/message/attributes.py (+2/-0)
checkbox/scripts/shadowd.py (+78/-0)
checkbox/scripts/submit.py (+83/-28)
checkbox/shadowd/queue.py (+9/-12)
checkbox/shadowd/sender.py (+59/-48)
checkbox/shadowd/starter.py (+128/-0)
checkbox/shadowd/tests/test_sender.py (+10/-8)
configs/checkbox.conf (+9/-0)
To merge this branch: bzr merge lp://staging/~cr3/checkbox-core/shadowd
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Marc Tardif Pending
Review via email: mp+104197@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

I would add this function to properly close the connection in enqueue():

    def disconnect(self, sender):
        if not self.is_active:
            return

        if queue_disconnect(sender) < 0:
            raise ApplicationError("Failed to close connection.")

        self.is_active = False

And probably check for errors and raise ApplicationError in the reschedule command.

But both can be implemented later, so approved !

review: Approve
Revision history for this message
Marc Tardif (cr3) wrote :

I've applied both your suggestions and merged into trunk. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: