Merge lp://staging/~cprov/uci-engine/tarmac-multienv into lp://staging/uci-engine

Proposed by Celso Providelo
Status: Merged
Approved by: Celso Providelo
Approved revision: 927
Merged at revision: 921
Proposed branch: lp://staging/~cprov/uci-engine/tarmac-multienv
Merge into: lp://staging/uci-engine
Diff against target: 359 lines (+111/-25)
15 files modified
bin/called-by-tarmac.py (+27/-4)
juju-deployer/deploy.py (+3/-3)
juju-deployer/relations.yaml (+3/-0)
juju-deployer/services.yaml.tmpl (+13/-0)
tests/deployers.py (+18/-0)
tests/test_britney.py (+4/-10)
tests/test_bsbuilder.py (+2/-0)
tests/test_image_builder.py (+2/-0)
tests/test_ppacreator.py (+2/-0)
tests/test_publisher.py (+2/-0)
tests/test_rabbit.py (+2/-0)
tests/test_test_runner.py (+4/-0)
tests/test_ticket_system.py (+1/-6)
tests/test_validator.py (+2/-0)
tests/test_webui.py (+26/-2)
To merge this branch: bzr merge lp://staging/~cprov/uci-engine/tarmac-multienv
Reviewer Review Type Date Requested Status
Vincent Ladeuil (community) Approve
Francis Ginther Needs Information
Review via email: mp+246333@code.staging.launchpad.net

Commit message

Supporting multi-system deployment for tests.

Description of the change

Supporting multi-system deployment for tests.

`called-by-tarmac`.py was modified to deploy one or more systems before running the tests, it was done under the premise that system *can* co-exist on the same tenant, i.e common services will be shared (e.g. rabbit).

`DeployerTest` was extended to require an specific service, if not available the test is skipped. Existing integration tests were adjusted.

In order to test the feature a minimal 'ci-ubuntucore' configuration was created for deploying rabbit, TR and Apache. There is also an integration test checking that the apache is alive but not configured (:-/).

To post a comment you must log in.
926. By Celso Providelo

typo

Revision history for this message
Francis Ginther (fginther) wrote :

A novel way to solve the problem. Just have a question inline.

review: Needs Information
Revision history for this message
Vincent Ladeuil (vila) wrote :

Excellent !

I like the way this makes the test dependency purely declarative.

Only one minor nit inline otherwise, good to land.

review: Needs Fixing
Revision history for this message
Celso Providelo (cprov) wrote :

Thanks Francis and Vincent,

I've extended the base test class to fail if 'required_service' is not provided by client implementations, it will force us to write clearer tests.

Let's see if tarmac likes it too.

927. By Celso Providelo

Addressing review comments, 'required_service' becomes mandatory for test implementations.

Revision history for this message
Vincent Ladeuil (vila) wrote :

\o/

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches