Merge lp://staging/~cprov/squid/snap into lp://staging/~squid/squid/trunk
- snap
- Merge into trunk
Status: | Rejected | ||||
---|---|---|---|---|---|
Rejected by: | Robert Collins | ||||
Proposed branch: | lp://staging/~cprov/squid/snap | ||||
Merge into: | lp://staging/~squid/squid/trunk | ||||
Diff against target: |
204 lines (+188/-0) 3 files modified
parts/plugins/x-squid.py (+81/-0) snapcraft.yaml (+24/-0) squid.conf (+83/-0) |
||||
To merge this branch: | bzr merge lp://staging/~cprov/squid/snap | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Alex Rousskov | Needs Fixing | ||
Review via email: mp+297663@code.staging.launchpad.net |
Commit message
Description of the change
Very basic snap setup for Squid.
There are still many details to sort out (devmode, missing libraries, custom config with hardcoded paths), but should be sufficient to illustrate how thin the snap-layer would be.
Comments and suggestion highly appreciated.
Alex Rousskov (rousskov) wrote : | # |
If these "snap" files are distributed with Squid, then the configuration file should probably be dynamically derived/computed from squid.conf.default. Statically copying the default once means the copy will become stale/inconsistent with what Squid provides.
Celso Providelo (cprov) wrote : | # |
Alex,
Thanks for the quick response on this.
IMHO, having snapcraft.yaml upstream is actually the best way to keep it from bit-rotting, mainly because it will be visible and owned by everyone actually working on upstream changes. With the advantage of hooking effective CI mechanisms to quickly build (verify) and ship changes quickly, like in https:/
I think it sets the right sense of shared ownership and also provides a very short-pipeline for testing and distributing improvements. While a separate (overlay) branch would take many additional hops and coordination to go from fix-landed to fix-distributed to affected people (the traditional distance between upstream & distributions).
Let me know what you think while I implement your suggestions to make the snap files intervention clearer (boilerplate template, more explicit directly structure, computing a suitable configuration file)
Alex Rousskov (rousskov) wrote : | # |
I am not sure I follow your argument. Committing X into Squid source tree might create a sense of shared ownership (whatever that means), but does not automagically keep X up to date. This is especially true for any X that does not affect Squid build and mainstream functionality. For X to actually be kept up to date, somebody active within the Squid project needs to know and care about X enough to keep it updated. AFAICT, there is no such person for X=snapcraft. Please correct me if I am wrong.
Please note that I am not arguing for a separate/overlay Squid branch containing X. I am arguing for a separate project, wiki page, whatever. The Squid Project can recommend and even host that project/page, of course.
In other words, if somebody wants to maintain X that helps folks build Squid but does not need to be tightly integrated with Squid sources and does not have a long-term Squid person behind it, then X should be kept separate from Squid because keeping X separate would decrease overheads for maintaining it and avoid polluting Squid with stale stuff (in case it does become stale).
Robert Collins (lifeless) wrote : | # |
I agree with Alex.
This is no more or less portable a packaging system that BSD ports, RPM specs, debian/rules etc: its packaging system specific. While I think its entirely appropriate for an upstream project that is publishing e.g. debs to have the rules for that in-tree, the Squid project is not currently publishing snaps for any plaform (and given they are currently Ubuntu-only, that seems unlikely).
Given Canonical is building snappy, has motivation to create and keep the packaging metadata up to date, and (so far at least) noone in squid core is engaged with that, I recommend keeping the snap ruleset in Canonical/Ubuntu's repository as is done for debian/rules.
Note too that the license is incorrect if these *were* to be in squid itself.
Amos Jeffries (yadi) wrote : | # |
Dear!
It is so exciting to tell you about what happened yesterday, you should better read it yourself <http://
Typos courtesy of my iPhone, squid3
Amos Jeffries (yadi) wrote : | # |
Dear!
Look what I've just found for you, you'll be surprised, more info here <http://
Rushing, squid3
Amos Jeffries (yadi) wrote : | # |
Hey!
I've had very nice experience in using that new stuff, give it a try too http://
Sent from a prehistoric stone tablet, squid3
Sent from Mail for Windows 10
Amos Jeffries (yadi) wrote : | # |
Hello friend,
I was just wondering about your opinion on that stuff, please take a look and tell me what you think http://
Typos courtesy of my iPhone, squid3
Sent from Mail for Windows 10
Amos Jeffries (yadi) wrote : | # |
Dear,
Have you ever seen such crazy stuff? It's just so unusual and amazing, check it out here http://
Yours faithfully, Vincent Rosenberg
From: mp297663 [mailto:<email address hidden>]
Sent: Friday, July 14, 2017 1:30 PM
To: <email address hidden>
Subject: ???? ??? :D
Are you in the US? I think your best bet would be to go to your local post office and pick up some flat rate shipping boxes and pack up your diapers. See how many boxes you'll need and then add up the postage for each box. The boxes are free and you pay per box (price varies depending on size). Then it shouldn't matter where you're shipping to (provided you're shipping to the US.)
Sent from Mail for Windows 10
Amos Jeffries (yadi) wrote : | # |
Greetings!
I just wished to say Hi there and also demonstrate something awesome, just take a look http://
Warm regards, Forrest Wyatt
From: mp297663 [mailto:<email address hidden>]
Sent: Thursday, August 17, 2017 2:21 PM
To: <email address hidden>
Subject: Me too dude.
I tend to dream very physically, seeing and feeling around me. I can hear, taste, move around, and feel pain. There's usually other people with their own behavior, and I can speak to them if they let me, and have conversations. But it depends on how they feel. I can also travel in these dreams and can go back to places that I dreamed of before.
Sent from Mail for Windows 10
Amos Jeffries (yadi) wrote : | # |
Hello!
I've got great news for you, I'm so thrilled) You'll love it! Please take a look http://
Wishes, Fredrick Fournier
From: mp297663 [mailto:<email address hidden>]
Sent: Sunday, September 17, 2017 4:53 AM
To: <email address hidden>
Subject: Cock magic?
Well, here's where we need to make the distinction between *sex* and *gender*. *Sex* is whether you have a penis or a vagina, or a mix of the two (intersex). *Gender* is male, female, or whatever you identify as. If you are MtF transgender, your sex is male (unless you go through surgery and/or HRT), but your gender is female.
So, sex is what you're born with. Although I'm not a doctor, I assume that if you're transgender, you'd recieve doses of medicine according to your sex rather than your gender.
Sent from Mail for Windows 10
Amos Jeffries (yadi) wrote : | # |
Hello!
Take a look at what I've just found! It is something really amazing, you will need to notice that! Take a look http://
Faithfully, Helen Ho
Amos Jeffries (yadi) wrote : | # |
Hi,
I've started a new project just lately, please have a look at a few examples of my recent works here http://
Speak to you later, Leroy Vera
From: mp297663 [mailto:<email address hidden>]
Sent: Tuesday, December 05, 2017 6:08 AM
To: <email address hidden>
Subject: Shotgun armpit!
The Izzet guildgate is still one of my favorite pieces of magic art, my sister got me a playmat of it for Christmas and I'm tempted to just hang it on the wall. I couldn't find any way to throw you a couple bucks, but I don't wanna rip you off either...do you have paypal or anything?
Keep up the great work man, I really dig your style
Sent from Mail for Windows 10
Amos Jeffries (yadi) wrote : | # |
I've been looking for something on-line and I've just accidentally locate that beautiful things , you've got to see them ! Just seem http://
Amos Jeffries (yadi) wrote : | # |
Whether you want to go to Tenerife or Tokyo, we'll find low cost flights to get you there.
We also find the cheapest hotels and car hire deals.<br>
Just dial: <a style="font-weight: bold; font-size:125%;" href="tel:
Skyscanner is free! When you find your flights and dial (888) 369-2751, we redirect your call through directly to the airline or travel agent.<br>We never charge you commission. Nor do we add hidden fees. See more ways we put you first.
Acclaimed flight comparison Skyscanner is an award winning site recommended by: The Independent, The Guardian, Which? Travel, BBC Radio 1 and more!<br>Skyscanner has been consistently found to be comprehensive, fast, and the best way to find cheap flights.<br>
Just dial: <a style="font-weight: bold; font-size:125%;" href="tel:
Let’s get social! Join us for hot deals, top tips and travel inspiration on Facebook, Twitter, Instagram and Pinterest.
Find the perfect place to stay
The Trip by Skyscanner community has reviewed tens of thousands of hotels around the world so you can always find the perfect place to stay, based on your tribe and your price range.
Simply select your destination, dial <a style="font-weight: bold; font-size:125%;" href="tel:
And now Trip by Skyscanner searches all the top booking sites to make sure to always find you the lowest price.
Check out some of our most popular destinations:<br>
<table width="
Amos Jeffries (yadi) wrote : | # |
Whether you want to go to Tenerife or Tokyo, we'll find low cost flights to get you there.
We also find the cheapest hotels and car hire deals.<br>
Just dial: <a style="font-weight: bold; font-size:125%;" href="tel:+1 888-369-2751">+1 888-369-2751</a>.
Skyscanner is free! When you find your flights and dial (888) 369-2751, we redirect your call through directly to the airline or travel agent.<br>We never charge you commission. Nor do we add hidden fees. See more ways we put you first.
Acclaimed flight comparison Skyscanner is an award winning site recommended by: The Independent, The Guardian, Which? Travel, BBC Radio 1 and more!<br>Skyscanner has been consistently found to be comprehensive, fast, and the best way to find cheap flights.<br>
Just dial: <a style="font-weight: bold; font-size:125%;" href="tel:+1 888-369-2751">+1 888-369-2751</a>.
Let’s get social! Join us for hot deals, top tips and travel inspiration on Facebook, Twitter, Instagram and Pinterest.
Find the perfect place to stay
The Trip by Skyscanner community has reviewed tens of thousands of hotels around the world so you can always find the perfect place to stay, based on your tribe and your price range.
Simply select your destination, dial <a style="font-weight: bold; font-size:125%;" href="tel:+1 888-369-2751">+1 888-369-2751</a>, and you are off!
And now Trip by Skyscanner searches all the top booking sites to make sure to always find you the lowest price.
Check out some of our most popular destinations:<br>
<table width="
Amos Jeffries (yadi) wrote : | # |
Whether you want to go to Tenerife or Tokyo, we'll find low cost flights to get you there.
We also find the cheapest hotels and car hire deals.<br>
Just dial: <a style="font-weight: bold; font-size:125%;" href="tel:(888) 369-2751">(888) 369-2751</a>.
Skyscanner is free! When you find your flights and dial (888) 369-2751, we redirect your call through directly to the airline or travel agent.<br>We never charge you commission. Nor do we add hidden fees. See more ways we put you first.
Acclaimed flight comparison Skyscanner is an award winning site recommended by: The Independent, The Guardian, Which? Travel, BBC Radio 1 and more!<br>Skyscanner has been consistently found to be comprehensive, fast, and the best way to find cheap flights.<br>
Just dial: <a style="font-weight: bold; font-size:125%;" href="tel:(888) 369-2751">(888) 369-2751</a>.
Let’s get social! Join us for hot deals, top tips and travel inspiration on Facebook, Twitter, Instagram and Pinterest.
Find the perfect place to stay
The Trip by Skyscanner community has reviewed tens of thousands of hotels around the world so you can always find the perfect place to stay, based on your tribe and your price range.
Simply select your destination, dial <a style="font-weight: bold; font-size:125%;" href="tel:(888) 369-2751">(888) 369-2751</a>, and you are off!
And now Trip by Skyscanner searches all the top booking sites to make sure to always find you the lowest price.
Check out some of our most popular destinations:<br>
<table width="
Unmerged revisions
- 14715. By Celso Providelo
-
Snapcraft setup.
Why is that a good idea to distribute this "snap" with Squid itself? If it lives inside Squid, it will be more difficult to update and, hence, it is more likely to rot.
The new "parts/plugins/" directory seem to be misnamed -- this "snap" is not a "part" of Squid and is not a Squid "plugin".
Please use scripts/ boilerplate. h text for boilerplates if possible.