core-image-watcher

Merge lp://staging/~cprov/core-image-watcher/fix-udf-call into lp://staging/core-image-watcher

  1. fix-udf-call
  2. Merge into trunk
Proposed by Celso Providelo
Status: Merged
Approved by: Celso Providelo
Approved revision: 10
Merged at revision: 9
Proposed branch: lp://staging/~cprov/core-image-watcher/fix-udf-call
Merge into: lp://staging/core-image-watcher
Diff against target: 68 lines (+18/-16)
1 file modified
core_image_watcher/__init__.py (+18/-16)
To merge this branch: bzr merge lp://staging/~cprov/core-image-watcher/fix-udf-call
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+254471@code.staging.launchpad.net

Commit message

Fix u-d-f call (typo, extra space) and other minor style tweaks.

Description of the change

Fix u-d-f call (typo, extra space) and other minor style tweaks.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

There was a typo that was forcing the use of shell=True that can be fixed. Otherwise the style tweaks look good.

review: Needs Fixing
lp://staging/~cprov/core-image-watcher/fix-udf-call updated
10. By Celso Providelo

Fixed the u-d-f cmdline typo and remove shell=True

Revision history for this message
Celso Providelo (cprov) wrote :

Comments addressed, Francis. Thanks for double checking my hack.

Revision history for this message
Francis Ginther (fginther) wrote :

Approve.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches