core-image-watcher

Merge lp://staging/~cprov/core-image-watcher/config-fixes into lp://staging/core-image-watcher

  1. config-fixes
  2. Merge into trunk
Proposed by Celso Providelo
Status: Merged
Approved by: Celso Providelo
Approved revision: 14
Merged at revision: 11
Proposed branch: lp://staging/~cprov/core-image-watcher/config-fixes
Merge into: lp://staging/core-image-watcher
Prerequisite: lp://staging/~cprov/core-image-watcher/proper-hostname
Diff against target: 38 lines (+3/-3)
3 files modified
README.rst (+1/-1)
core-service.conf (+1/-1)
core_image_watcher/__init__.py (+1/-1)
To merge this branch: bzr merge lp://staging/~cprov/core-image-watcher/config-fixes
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+254768@code.staging.launchpad.net

Commit message

Fix default u-d-f configuration 'channel' value (missing 'ubuntu-core/' prefix).

Description of the change

Fix default u-d-f configuration 'channel' value (missing 'ubuntu-core/' prefix).

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Line 57 in core_image_watcher/__init__.py also needs to be changed:

'--channel={}'.format(channel),

I applied this fix and was able to get the core-image-publisher to successfully start an upload.

review: Needs Fixing
lp://staging/~cprov/core-image-watcher/config-fixes updated
14. By Celso Providelo

Removing hardcoded channel prefix.

Revision history for this message
Celso Providelo (cprov) wrote :

Thanks for find this problem, Francis.

Code fixed.

Revision history for this message
Francis Ginther (fginther) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches