Merge lp://staging/~cprov/core-image-publisher/lint into lp://staging/core-image-publisher
Proposed by
Celso Providelo
| Status: | Needs review |
|---|---|
| Proposed branch: | lp://staging/~cprov/core-image-publisher/lint |
| Merge into: | lp://staging/core-image-publisher |
| Diff against target: |
26 lines (+9/-1) 2 files modified
called-by-tarmac.py (+7/-0) test_requirements.txt (+2/-1) |
| To merge this branch: | bzr merge lp://staging/~cprov/core-image-publisher/lint |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomi Richards (community) | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Running pylint checks before merging.
Description of the change
Running pylint checks before merging.
Warnings, Recommendations and Style checks are disabled for now, we only care about Errors.
To post a comment you must log in.
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
review:
Needs Fixing
Unmerged revisions
- 27. By Celso Providelo
-
Running pylint check before merging.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
My vote is not to merge this. As shown in the diff, pylint doesn't understand some pretty straight-forward things, and forces us to either make our code less clear, or litter linter disabling comments everywhere.
If silly errors are landing in trunk, let's make sure we do a better job of reviewing MPs, writing tests, and/or manually testing our code (as appropriate to the situation).