Juju Charms Collection
logstash package

Merge lp://staging/~cprov/charms/trusty/logstash/heap_size into lp://staging/~canonical-is-sa/charms/trusty/logstash/logstash2

  1. Trusty Tahr (14.04)
  2. heap_size
  3. Merge into logstash2
Proposed by Celso Providelo
Status: Merged
Merged at revision: 62
Proposed branch: lp://staging/~cprov/charms/trusty/logstash/heap_size
Merge into: lp://staging/~canonical-is-sa/charms/trusty/logstash/logstash2
Diff against target: 98 lines (+29/-2)
5 files modified
config.yaml (+5/-0)
files/limits.conf (+3/-0)
files/upstart/logstash-indexer.conf (+2/-1)
hooks/config-changed (+5/-1)
hooks/install (+14/-0)
To merge this branch: bzr merge lp://staging/~cprov/charms/trusty/logstash/heap_size
Reviewer Review Type Date Requested Status
Michael Nelson (community) Approve
Guillermo Gonzalez Pending
Review via email: mp+311671@code.staging.launchpad.net

This proposal supersedes a proposal from 2016-11-23.

Commit message

Allowing changing the logstash maximum heap size as a configuration.

Description of the change

Allowing changing the logstash maximum heap size as a configuration.

Defaults to 1000m instead of the application 500m default value and allow adjustments.

To post a comment you must log in.
Revision history for this message
Guillermo Gonzalez (verterok) wrote : Posted in a previous version of this proposal

Celso,

If this is to apply it to the OLS ELK, it's using a a different charm:

lp:~canonical-is-sa/charms/trusty/logstash/logstash2;revno=61,overwrite=true

the spec in use (for both staging and production) is: is/mojo-is-logging-kibana/ @ lp:canonical-mojo-specs.

review: Needs Information
Revision history for this message
Michael Nelson (michael.nelson) wrote : Posted in a previous version of this proposal

LGTM. Note that in the ES charm, we're explicitly giving unlimited memlock. See the task at:

http://bazaar.launchpad.net/~onlineservices-charmers/charms/trusty/elasticsearch/elasticsearch2/view/head:/tasks/install-elasticsearch.yml#L49

which installs this template:

http://bazaar.launchpad.net/~onlineservices-charmers/charms/trusty/elasticsearch/elasticsearch2/view/head:/templates/limits.conf

review: Approve
lp://staging/~cprov/charms/trusty/logstash/heap_size updated
61. By Celso Providelo

Special (no-) limits configuration for logstash, so it can eat as much memory it is configured too.

Revision history for this message
Michael Nelson (michael.nelson) wrote :

+1 from me (see note above about using memlock)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches