Merge lp://staging/~cprov/adt-cloud-worker/selftest into lp://staging/adt-cloud-worker

Looks good as is. I had a few minor suggestions, but mostly just personal preference.

This looks good to me as well. I agree with Paul's suggestions as well but don't see them as blocking.

Paul, Joe,

Thanks for the review.

I've updated the README as suggested and proposed a new change for the test_proxy checks, actually check access we depend on in production. Since they are only 3 and tend to be gone once the sources get fixed, we can make the test reflect the exact conditions we expect in production, i.e. when the test fails we know what will be broken and can act accordingly.

Please don't add more shell code that we need to maintain.

I agree that a selftest suite is a great thing to have, but I think writing it as a bash script is a bad idea. This could be trivially written as a python test suite, and would be easier to extend and maintain over time.

I think you could have gotten away without making dep8/tests/__init__.py - but there's nothing wrong with it either.

Thanks for the python rewrite.

THomi,

Fine, python it is ... However, it carries a lot more test dependencies and specialties (allow-stderr) that were not a problem with the much simpler, main-stream and perfectly functional shell test suite.

This tendency of aiming for *bonus* points and twinkling stars, instead of getting things done on time, is what makes us kind of borderline mediocre ... We haven't reached the point where people start criticising our design choices and coding skills, simply because we have nothing to show :-/ I'd rather live with bad ideas that work than keep chasing tangential satisfaction on "perfect solutions" that do not serve their purpose.

That all said, enough ranting. Let's land the tests and use it to our benefit for validating other aspects of uci-nova.