Merge lp://staging/~cprov/adt-cloud-worker/log-cleanup into lp://staging/adt-cloud-worker
Proposed by
Celso Providelo
| Status: | Merged |
|---|---|
| Approved by: | Celso Providelo |
| Approved revision: | 31 |
| Merged at revision: | 29 |
| Proposed branch: | lp://staging/~cprov/adt-cloud-worker/log-cleanup |
| Merge into: | lp://staging/adt-cloud-worker |
| Diff against target: |
171 lines (+64/-20) 3 files modified
adt-service.conf (+5/-0) adt_cloud_worker/__init__.py (+58/-20) requirements.txt (+1/-0) |
| To merge this branch: | bzr merge lp://staging/~cprov/adt-cloud-worker/log-cleanup |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomi Richards (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Suppressing adt-run output from the logs, adding logstash & file logging handlers along with some messaging cleanup.
Description of the change
Suppressing adt-run output from the logs, adding logstash & file logging handlers along with some messaging cleanup.
To post a comment you must log in.
Revision history for this message
| Thomi Richards (thomir-deactivatedaccount) wrote | # |
review:
Approve
Revision history for this message
| Celso Providelo (cprov) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
<thomi> cprov: ok, only thing is, best practise is to do: logger.info("%s", var) not logger.info("%s" % (var)) or logger.
<cprov> thomi: I noticed in your MPs, let me fix mine
<thomi> cprov: also, in my MPs I set 'requests' to WARNING
<thomi> best make them all the same I guess
<thomi> cprov: otherwise, looks good
Looks good - suggest you fix the above two issues.