Merge lp://staging/~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-photos into lp://staging/ubuntu-desktop-accomplishments

Proposed by Charles Profitt
Status: Merged
Merged at revision: 77
Proposed branch: lp://staging/~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-photos
Merge into: lp://staging/ubuntu-desktop-accomplishments
Diff against target: 67 lines (+49/-0)
3 files modified
CATEGORIES (+1/-0)
accomplishments/ubuntu-desktop/en/multimedia/multimedia-added-photos.accomplishment (+9/-0)
scripts/ubuntu-desktop/multimedia/multimedia-added-photos.py (+39/-0)
To merge this branch: bzr merge lp://staging/~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-photos
Reviewer Review Type Date Requested Status
Rafał Cieślak Approve
Review via email: mp+109443@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

Thanks for this MP, Charles.
Although the script looks perfect, the documentation is far too brief. Would you mind expanding it a bit, explaining that images are usually kept in their directory, and maybe a note on how to do this? Note that this accomplishment documentation if for newbies, so although it seems obvious, it may be good to explain it at least a bit.
Also, your .accomplishment files does not contain 'collection = ubuntu-community' line, which is necessary.

I have also a tip for you: there is no need to copy your accomplishment to pl and bn directories - if you use the 0.2 daemon (available and almost stable in daily builds PPA), it will use the file from en directory, if there is no equivalent in a localized dir - so it saves some efforts (especially in UCA, where we have already ~30 localized directories) :)
Thanks again for your awesome work!

review: Needs Fixing
17. By Charles Profitt <email address hidden>

changed accomplishment file

18. By Charles Profitt <email address hidden>

added more description to photos description

Revision history for this message
Charles Profitt (cprofitt) wrote :

Added a bit more, but not sure if it is enough.

Charles

On Sun, 2012-06-10 at 11:56 +0000, Rafal Cieślak wrote:
> Review: Needs Fixing
>
> Thanks for this MP, Charles.
> Although the script looks perfect, the documentation is far too brief. Would you mind expanding it a bit, explaining that images are usually kept in their directory, and maybe a note on how to do this? Note that this accomplishment documentation if for newbies, so although it seems obvious, it may be good to explain it at least a bit.
> Also, your .accomplishment files does not contain 'collection = ubuntu-community' line, which is necessary.
>
> I have also a tip for you: there is no need to copy your accomplishment to pl and bn directories - if you use the 0.2 daemon (available and almost stable in daily builds PPA), it will use the file from en directory, if there is no equivalent in a localized dir - so it saves some efforts (especially in UCA, where we have already ~30 localized directories) :)
> Thanks again for your awesome work!

Revision history for this message
Rafał Cieślak (rafalcieslak256) wrote :

This is not satisfying, but let's consider this a bug, so that others may expand it.
Thanks again Charles for this accom, I have just merged it in! And sorry for the delay.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches