Ubuntu Desktop Accomplishments

Merge lp://staging/~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music into lp://staging/ubuntu-desktop-accomplishments

multimedia-added-music
Merge into trunk

Proposed by Charles Profitt on 2012-06-08

Status:

Merged

Merged at revision:

Proposed branch:

lp://staging/~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music

Merge into:

lp://staging/ubuntu-desktop-accomplishments

Diff against target:

150 lines (+113/-8)

5 files modified

accomplishments/ubuntu-desktop/bn/multimedia/musicinrhythmbox.accomplishment (+19/-0)
accomplishments/ubuntu-desktop/en/multimedia/musicinrhythmbox.accomplishment (+19/-0)
accomplishments/ubuntu-desktop/pl/multimedia/musicinrhythmbox.accomplishment (+19/-0)
scripts/ubuntu-desktop/multimedia/multimedia-added-music.py (+25/-8)
scripts/ubuntu-desktop/multimedia/musicinrhythmbox.py (+31/-0)

To merge this branch:

bzr merge lp://staging/~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music

Undecided

Fix Committed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Rafał Cieślak		2012-06-08	Approve on 2012-06-10
Review via email: mp+109439@code.staging.launchpad.net

Description of the change

Added improvements to music added script with fixed recursion for sub-folders
Added Music in Rhythmbox award and script

Revision history for this message

Rafał Cieślak (rafalcieslak256) wrote on 2012-06-10:

Thanks for your awesome work, Charles!
I have spotted some problems with your accomplishments, which caused them not to display in the viewer (have you actually tested them?). However, they were very simple, so I fixed them for you.
First thing was that your new accomplishment depended on itself - which made it always locked. Second - there was missing 'collection = ubuntu-desktop', and the category was incorrect, I changed it to 'category = Multimedia'. Also - the script file was not marked as executable.
Anyway, I am merging, that's a nice accomplishment, and thanks for fixing the added-music script! ;-)

review: Approve

Revision history for this message

Charles Profitt (cprofitt) wrote on 2012-06-10:

Rafal:

Thanks... I will make sure to check those better. I think I added the depends when I had two steps and removed it w/o testing again.

---- "Rafal Cieślak" <email address hidden> wrote:
> Review: Approve
>
> Thanks for your awesome work, Charles!
> I have spotted some problems with your accomplishments, which caused them not to display in the viewer (have you actually tested them?). However, they were very simple, so I fixed them for you.
> First thing was that your new accomplishment depended on itself - which made it always locked. Second - there was missing 'collection = ubuntu-desktop', and the category was incorrect, I changed it to 'category = Multimedia'. Also - the script file was not marked as executable.
> Anyway, I am merging, that's a nice accomplishment, and thanks for fixing the added-music script! ;-)
> --
> https://code.launchpad.net/~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music/+merge/109439
> You are the owner of lp:~cprofitt/ubuntu-desktop-accomplishments/multimedia-added-music.